Closed X-Guardian closed 5 years ago
Merging #324 into dev will increase coverage by
<1%
. The diff coverage is93%
.
@@ Coverage Diff @@
## dev #324 +/- ##
====================================
+ Coverage 75% 75% +<1%
====================================
Files 12 12
Lines 1581 1651 +70
Branches 2 2
====================================
+ Hits 1186 1251 +65
- Misses 393 398 +5
Partials 2 2
I haven't added instructions to the README yet. I'll do that once everyone has reviewed the implementation details.
Awesome stuff @X-Guardian! I haven't had a chance to do a full review on it, but a quick suggestion is to separate the strings into a localization file as per other modules. Will be great to get this in.
Will do @PlagueHO.
@X-Guardian Awesome work on this! 😃
@PlagueHO can you sign off on this implementation (and maybe review) so that @X-Guardian can update the README.md. That is my only comment left, and after that this PR looks good to me.
Did you see my comments on #227 and #228?
Hi @PlagueHO . Have you had chance to look at this PR yet? It would be great to get this implemented.
Hi @X-Guardian , @johlju - sorry for not completing this last night, I was flying home. I'm trying to sign off on the bus but reviewable isnt working on my phone.
Pull Request (PR) description
This PR adds the following:
Publish-WikiContent
which publishes the contents of a DSC Resource Module Wiki Content artifact from an AppVeyor job to the relevant GitHub Wiki repository.PublishWikiContent
option to theInvoke-AppVeyorDeployTask
OptIn
parameter which if set, will call thePublish-WikiContent
function with the relevant parameters.To enable the function, the following process needs to be followed:
repo/public_repo
permissions for a user that has at leastCollaborator
access to the relevant DSC Module GitHub repository.appveyor.yml
file of the relevant DSC Module GitHub repository:github_access_token
to theenvironment
section.PublishWikiContent
OptIn property to theInvoke-AppVeyorDeployTask
function call in thedeploy_script
section as follows:Notes
username
andemail
for the Git commit needs to be specified as parameters to thePublish-WikiContent
function. These currently default toAppVeyor
andappveyor@microsoft.com
, but can be changed if required.As an example, this fork of the xActiveDirectory repository has the
Publish-WikiContent
enabled, with this example Pull Request and AppVeyor build deploying the Wiki.This Pull Request (PR) fixes the following issues
Task list
This change is