PowerShell / DscResource.Tests

Common meta tests for PowerShell DSC resources repositories.

MIT License

51 stars 49 forks source link

Keyword check- suggested corrections #350

Closed SSvilen closed 4 years ago

SSvilen commented 5 years ago

Pull Request (PR) description

I have added correction for the keyword checks (capital letters and missing single space between keyword and parenthesis). May be this would help someone in the future. Let me know what you think.

This Pull Request (PR) fixes the following issues

None.

Task list

[x] Added an entry under the Unreleased section of the change log in the CHANGELOG.md. Entry should say what was changed, and how that affects users (if applicable).
[ ] Documentation added/updated in README.md.
[ ] Comment-based help added/updated for all new/changed functions.
[ ] Localization strings added/updated in all localization files as appropriate.
[ ] Unit tests added/updated.
[x] New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

This change is

SSvilen commented 5 years ago

Hi @PlagueHO,

would you have the time to review this one? It's a relatively small change.

PlagueHO commented 5 years ago

Hi @SSvilen - can you fix the conflicts on this one and I'll get it through. Sorry about the recent delays.

gaelcolas commented 5 years ago

Also, @SSvilen we're moving AnalyzerRules to its own modules, so please submit a similar PR for dsccommunity/DscResource.AnalyzerRules before this can be merged.

Thanks, and sorry for the overhead.

codecov-io commented 5 years ago

Codecov Report

Merging #350 into dev will decrease coverage by <1%. The diff coverage is 100%.

@@         Coverage Diff         @@
##            dev   #350   +/-   ##
===================================
- Coverage    84%    84%   -1%     
===================================
  Files        12     12           
  Lines      1750   1767   +17     
  Branches      2      2           
===================================
+ Hits       1477   1491   +14     
- Misses      271    274    +3     
  Partials      2      2

gaelcolas commented 5 years ago

Reflecting the comment from the DscResource.AnalyzerRules, you're missing unit tests for New-SuggestedCorrection function.

PlagueHO commented 4 years ago

Hi @gaelcolas, @SSvilen - where are we at with this one? Is it still waiting changes?

SSvilen commented 4 years ago

Hi @PlagueHO - this is already implemented in DscResource.AnalyzerRules and I think it does not make sense to merge it here also. (as this module will be retired). I'm closing this one.