Hashtable check - quick fix for LF end of line

[SSvilen]

Pull Request (PR) description

This PR extends the Measure-Hashtable function to cover LF end of line.

This Pull Request (PR) fixes the following issues

None

Task list

• [x] Added an entry under the Unreleased section of the change log in the CHANGELOG.md. Entry should say what was changed, and how that affects users (if applicable).
• [ ] Documentation added/updated in README.md.
• [ ] Comment-based help added/updated for all new/changed functions.
• [ ] Localization strings added/updated in all localization files as appropriate.
• [ ] Unit tests added/updated.
• [x] New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

---

This change is 

[codecov-io]

Codecov Report

Merging #355 into dev will decrease coverage by <1%. The diff coverage is 100%.

@@         Coverage Diff         @@
##            dev   #355   +/-   ##
===================================
- Coverage    84%    84%   -1%     
===================================
  Files        12     12           
  Lines      1750   1750           
  Branches      2      2           
===================================
- Hits       1477   1474    -3     
- Misses      271    274    +3     
  Partials      2      2

[PlagueHO]

Hi @SSvilen, I'm just going to check this against ComputerManagementDsc and NetworkingDsc and see if it resolves the issues. We will also need to copy this change over into https://github.com/dsccommunity/DscResource.AnalyzerRules.

[PlagueHO]

Hi @SSvilen - I'm scratching my head over this one. All hash tables are failing the validation check when run in AppVeyor - but are fine when run locally.

See: https://ci.appveyor.com/project/PowerShell/networkingdsc?fullLog=true#L1293 https://github.com/PowerShell/NetworkingDsc/blob/dev/DSCResources/MSFT_DefaultGatewayAddress/MSFT_DefaultGatewayAddress.psm1#L60

Is it possible that there is an issue with the CRLF? I'm actually wondering if the problem is in this line: https://github.com/PowerShell/DscResource.Tests/blob/dev/DscResource.AnalyzerRules/DscResource.AnalyzerRules.psm1#L1110

The split is using CR rather than CRLF which might be a problem. I've not had time to dig into this further however.

[PlagueHO]

Hi @SSvilen - the comment I made above (see https://github.com/PowerShell/DscResource.Tests/pull/355#issuecomment-552167007) was actually when I tried using your new branch. It doesn't look like it resolves the problem :cry: E.g. I ran NetworkingDsc and ComputerManagementDsc against your branch with the updated RegEx (https://github.com/PowerShell/DscResource.Tests/blob/fc41c12a292fd5a691050ed19fd77d8c404042f8/DscResource.AnalyzerRules/DscResource.AnalyzerRules.psm1#L1113) and it still fails.

So I'm thinking there must be something else going on - which is why I'm wondering about the split.

The reason I query the split, is that on a file with CRLF line endings, that split will result in all of the strings in the array (except entry 0) beginning with a \n - which might mess up the RegEx matches on [1]. I'm just guessing though.

[SSvilen]

That is strange, because I tested it on the AppVeyor server directly.. I'll give it a try tonight again..

[SSvilen]

Hi @PlagueHO,

I actually tested NetworkingDsc against this fix and it passes all appveyor tets. What I changed is:

1. Fix a cople of hahtable styling violations
2. In appveyor.yaml I changed the source of DSCResources.Tests to my branch Here are the changes.

The tests results are here.

Is there anything else I should test?

[PlagueHO]

Hi @SSvilen - I definitely am not sure what was going on. But you're right - it appears this has fixed the issue. Sorry about the confusion. Must have too many branches going at the moment!