search

PowerShell / DscResources

Central repository for PowerShell Desired State Configuration (DSC) resources.
http://blogs.msdn.com/b/powershell/
MIT License
777 stars 205 forks source link

DSCResource.Tests not running on first call to invoke-pester #138

Open mbreakey3 opened 8 years ago

mbreakey3 commented 8 years ago

If a user downloads a module and then runs invoke-pester, right now the test template is set up to clone DSCResource.Tests into the module where the tests are being run. While the module is successfully being cloned into the module, those common tests will not be run on that first invoke-pester. I think this has to do with how Pester sets up the tests ahead of time before running them and since they're cloned afterwards, they get ignored. Once DSCResource.Tests exists in the module, the tests run smoothly with everything else. It seems this bug hasn't been caught before because when pester is run through appVeyor, the tests are cloned in the appveyor.yml file before pester is run.

johlju commented 6 years ago

@mbreakey3 Not sure how to resolve this. Only option I'm seeing is a guideline how the user get DscResource.Tests downloaded before invoking Invoke-Pester. Would that work?

There are unit tests in DscResource.Tests that tests the test framework which will also run, and the Meta.Tests.ps1 are just tests to verify code compliance against style guideline and best practices. There are no resource specific unit or integration tests in DscResource.Tests. I my though is that they are used to make sure a PR has gone through the "basic" tests (style guideline and best practices).

mbreakey3 commented 6 years ago

@johlju -Fixing this issue isn't too high on the priority list so I think a guideline would be fine for now.