PowerShell / DscResources

Central repository for PowerShell Desired State Configuration (DSC) resources.
http://blogs.msdn.com/b/powershell/
MIT License
776 stars 205 forks source link

Add GitHub App "Review Me" to DSC Resource Kit repositories #430

Open johlju opened 6 years ago

johlju commented 6 years ago

I suggest we look at adding the GitHub App Review Me to all DSC Resource Kit repositories. It will help by adding the needs review tag when all the status checks are green. One more step to automate maintainer repetitive tasks.

.github/review-me.yml

# Configuration for probot-review-me - https://github.com/z0al/probot-review-me
when:
  continuous-integration/appveyor/pr: success
  license/cla: success

label: needs review
johlju commented 6 years ago

First out is the repository DscResource.Tests, to test the functionality in real scenarios.

johlju commented 6 years ago

Problems using Review Me (after real scenario tests):

Where the last one is the most serious one for our current workflow. It will set 'needs review' on every PR that has a 'waiting label'. I think we need to look at changing our workflow, or how the labels are used.

johlju commented 6 years ago

Uninstalled Review Me from DscResource.Tests for the time being due to the problems above. I have not remove the configuration file yet, I keep this issue open to see if we can get any improvements to the app, or a reminder to remove the configuration file before closing this issue.