search

PowerShell / DscResources

Central repository for PowerShell Desired State Configuration (DSC) resources.
http://blogs.msdn.com/b/powershell/
MIT License
777 stars 204 forks source link

Opened Wiki #541

Open VLoub opened 4 years ago

VLoub commented 4 years ago

Hello,

I found second MS repo with opened wiki for public update. https://github.com/dsccommunity/ComputerManagementDsc/issues/296#issuecomment-574032246

I like DSC and implementing it but i am not sure if GitHub wiki should be my source now 👎

Could some one check rest of them?

Thanks

PlagueHO commented 4 years ago

Hi @VLoub - thanks for raising this. I fixed this a few days ago after it was raised over there. Can you confirm if it is fixed?

I did also check the other ones I maintain. @johlju , @X-Guardian - you might want to check yours. I think there aren't too many more that have Wikis.

PlagueHO commented 4 years ago

I did check ActiveDirectoryDsc and SQLServerDsc as well and it did have the Wiki open. As I have permissions I'll go through and check them myself. Actually many of them have it open. So I'm correcting them.

johlju commented 4 years ago

What setting is this? Is this a setting that need to be set on new repositories we create or is it secure by default? If not we should document this (I can fix that) under https://dsccommunity.org/guidelines/administration#create-github-repository.

X-Guardian commented 4 years ago

https://help.github.com/en/github/building-a-strong-community/changing-access-permissions-for-wikis.

I'm sure these were restricted when they were under the PowerShell account.

johlju commented 4 years ago

I’m not sure it was. Not for all repos. But @PlagueHO seemed to have gone through them all and enabled this. Just wonder if this setting is set by default when creating a new repo.

johlju commented 4 years ago

The link said it is only collaborators that are allowed to edit the wiki by default, so we don’t have to worry about this for new repos.

PlagueHO commented 4 years ago

It seemed to be most repos had the Wiki public, except for the ones that have had a Wiki for a while. The exception being ComputerManagementDsc. So I'm not exactly sure when/what caused the setting to not be set.

johlju commented 4 years ago

I'm guessing this setting was not default secure (or even available) to begin with when the repos was created several years ago, like Wikipedia. 🤔 Anyway, good that they have this setting enabled now. Once the repos can support the auto-doc there is no need for anyone to edit the wikis.