search

PowerShell / EditorSyntax

PowerShell syntax highlighting for editors (VS Code, Atom, SublimeText, TextMate, etc.) and GitHub!
MIT License
133 stars 45 forks source link

Bug fixes. Should fix: #12

Closed gravejester closed 8 years ago

gravejester commented 8 years ago

https://github.com/PowerShell/EditorSyntax/issues/9

https://github.com/PowerShell/EditorSyntax/issues/10

https://github.com/PowerShell/EditorSyntax/issues/11

msftclas commented 8 years ago

Hi @gravejester, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! You've already signed the contribution license agreement. Thanks!

The agreement was validated by Microsoft and real humans are currently evaluating your PR.

TTYL, MSBOT;

gerane commented 8 years ago

Nice!

gravejester commented 8 years ago

@gerane Turned out two of the issues were related, so easy fix :)

Thanks for testing and finding these bugs btw!

gerane commented 8 years ago

No problem. I should just be able to copy the TM language into code to try these changes out shouldn't I?

I use code as my daily driver, and I have always liked themes, so I will be paying closer attention for anything off.

gravejester commented 8 years ago

Yes, just copy the language file over the existing one, and restart code.

daviwil commented 8 years ago

Thanks man! I'll take a look at this later today when I'm back in Athens.

daviwil commented 8 years ago

@gerane, did the fixes resolve the issues for you when you tried it?

gerane commented 8 years ago

I haven't tried it yet. Got caught up in a bug in a vendor's product at work. So I've wasted the last couple days dealing with foreign support I can barely understand.

They blamed Microsoft like usual, even though I can't even begin to see how it is related to Microsoft. I think that is just their go to answer.

CodeCyclone commented 8 years ago

I tested this out and it worked for me by updating "C:\Program Files (x86)\Microsoft VS Code\resources\app\extensions\powershell\syntaxes\PowershellSyntax.tmLanguage"

daviwil commented 8 years ago

Hey @gravejester, sorry for the delay on getting this merged. Done now!

By the way, the VS Code team gave me write access to their repo so I should be able to approve your PRs there now ;)

ftischhauser commented 8 years ago

I'm still seeing some color coding issues even after replacing this file manually:

Example 1:

$email = "test@domain.com"

Example 2:

$XML = @"
<?xml version="1.0" encoding="UTF-16"?>
    <test>powershell.exe -Command "&amp; {if($var.'$name'){Write-Output 'hello world'}}"</test>
"@
Write-Output 'hello world'

Both work perfectly with VSCode 1.2.1 and vscode-powershell 0.6.1.

Thanks for looking into this :)