PowerShell / EditorSyntax

PowerShell syntax highlighting for editors (VS Code, Atom, SublimeText, TextMate, etc.) and GitHub!
MIT License
130 stars 42 forks source link

Syntax highlighting getting worse? #16

Closed Jaykul closed 6 years ago

Jaykul commented 8 years ago

What is going on with this project? Have we completely lost the ability to detect regressions?

$Whatever.Name -match "Id"

2016-07-28 12_08_17- untitled-1 - amsautomation - visual studio code

$Whatever.Name -match ".*Id"

2016-07-28 12_09_58- untitled-1 - amsautomation - visual studio code

This isn't acceptable.

gravejester commented 8 years ago

The problem with detecting regressions in a project like this, is that it will never be any better than the test scripts we test the changes against. When we pushed these changes everything was fine when tested against the test scripts. So really, these kinds of feedback is really important, and we need to get them added to the test script as well.

This particular issue, and really a bunch of similar issues that have been reported I think is because I tried to match variables with properties, like in your example. This turns out to be a lot harder to do correctly than I initially thought, so I'm going to disable this bit, which should "fix" a lot of the issues we are now seeing.

I apologize for not testing this better before pushing this particular "feature".

Jaykul commented 8 years ago

Well, the real problem is that there's nothing automated set up, so we're relying on visual inspections of code highlighting, and you don't have any test results you can throw in my face to say "hey dude, the tests passed, write better tests if you don't like it!" 😉

But yeah. I want something like the new sublime text test harness ;-)

https://www.sublimetext.com/docs/3/syntax.html#testing

gravejester commented 8 years ago

Oh. yeah, something like that would be great. I know the VSCode team try to do something automated, but it's a mess, hard-coded color codes etc. Would definitely have been cool to have something that would do the testing for us. When we get all the issues sorted out perhaps I'll have the time to look into something. Would be nice to be able to use Pester :)

omniomi commented 6 years ago

The two issues in the top comment are resolved. Regression is now checked for by atom-grammar-test and Jasmine.\

There are a total of 359 tests with 3459 assertions.