PowerShell / EditorSyntax

PowerShell syntax highlighting for editors (VS Code, Atom, SublimeText, TextMate, etc.) and GitHub!
MIT License
133 stars 45 forks source link

Improvements to Comment Based Help Keywords #175

Closed msftrncs closed 3 years ago

msftrncs commented 5 years ago

Fixes #136

This PR improves the scoping of comment based help keywords, specifically fixing the lack of highlighting for the keywords that do not accept arguments when used on single-line comment lines.

This required an optimization to the single-line comment (commentLine), and tweaks to the commentEmbeddedDocs matches. By utilizing a ^|\G pattern, it can be prevented that extra # be still permitted to match, which PowerShell does not permit. I also organized the keywords on their prospective matches alphabetically. On the match for keywords with arguments, I opened up the argument capture to all the available text, as there seems to be no additional rules that limit what PowerShell will accept.

There are no tests that cover this particular condition, since the testing engine uses single-line comments to hide the test expressions. commentBlock tests have not changed.

I am sure that #134 has not been reintroduced.