search

PowerShell / EditorSyntax

PowerShell syntax highlighting for editors (VS Code, Atom, SublimeText, TextMate, etc.) and GitHub!
MIT License
133 stars 45 forks source link

Scopes not being colorized in default vscode themes #5

Closed gravejester closed 6 years ago

gravejester commented 8 years ago

There are a number of scopes that we use in the PowerShell syntax highlighting definitions that are not currently colorized in the default themes in Visual Studio Code.

For instance:

Should we try to get some colors for these into the default themes? Or should we create our own PowerShell optimized versions of the default themes? I'm mainly thinking about the default light+ and dark+ themes.

I'd rather not use the "wrong" scope names just to get colors. This will only mess things up when you change to other themes.

daviwil commented 8 years ago

I'd prefer to stick with the right scope names and potentially make pull requests to VS Code's default themes if we can improve them for all languages. It'd be difficult to point people to PowerShell-specific versions of the default themes so I'd like to do things in the "official" way as much as possible.

I can help you get a PR through to VS Code if you can figure out a good way to light up these scopes correctly in their default themes. Showing some comparison with Sublime Text's highlighting for those scopes would also be helpful in convincing them to accept a PR.

gravejester commented 8 years ago

Ok. I can play around with the default themes a bit and paste some screenshots here for discussion. And when (if) we think we have found something that works, we can create a PR to try to get the default themes updated :)

daviwil commented 8 years ago

Sounds like a good plan!

gerane commented 8 years ago

Btw, @gravejester @daviwil, I have over 280 themes on the vscode gallery,

https://github.com/gerane/VSCodeThemes

I can try to start adding support for these, but might take me a while. I am always open for pull requests on them.

When code first came out, there were like 10 themes, and I'm a huge fan of editor customization and expansion, and I wasn't a big fan of the default themes. I had experience working with atom themes and porting those, so I scripted porting almost 300 themes.

I might need to see what a few of these look like so I know what I'm adding.

EDIT: I have 284 of the 375 themes up on the gallery. Roughly 75%. Here is a list of the top 10 Install counts for mine.

Theme-FlatlandMonokai - 8725 Theme-Batman - 2605 Theme-Github - 2475 Theme-Dark-Dracula - 2332 Theme-azure - 2055 Theme-Monokai - 2038 Theme-Zenburn - 1833 Theme-Solarized-dark - 1765 Theme-monokai-best - 1717 Theme-OceanicNext - 1638

So, as far as mine go, could start at the top with most installs.

gerane commented 8 years ago

Btw, I have a few insights on where VS Code themes fall short or don't look right compared to sublime.

Selected line highlight has given me huge headaches for example.

omniomi commented 6 years ago

Closing as a duplicate of #8 and because a number of the scopes have been changed since this was opened. @gravejester we should start a new discussion on scope names.