Closed JustinGrote closed 4 years ago
I came here to open this same issue, but @JustinGrote beat me to it. For years now, the community has been instructing people to use the \
Well, technically it is singular because it is not SecretsVaults
😅
But I still agree that SecretVault
sounds much better.
But to be honest, why not take it further and just call it Vault
only?
People call it different things like e.g. KeyVault
in the case of Azure and it can store secrets, keys and certificates. Therefore the word Secret
in SecretVault
isn't describing anything specific and a vault by definition already stores something valuable that only certain authorized people should be allowed access to, hence why I think including the word Secret
in the name does not add any meaning and is rather superfluous and potentially confusing.
And whilst we're at it, is the module not rather a VaultManagement
module?
@bergmeister The reason for the Secret
prefix is to identify the module in a pseudonamespace way, the same way that Az
is prepended to all azure commands. This is proper since this is probably not going to be a "in-the-box" module and those should probably be reserve for the future.
I'd agree module name should be probably Microsoft.Powershell.SecretManagement
instead.
Cmdlets, classes, module name has all been changed. So there is now a new module Microsoft.PowerShell.SecretManagement
in the repo.
Powershell convention dictates that plurality should not be present in cmdlet names, so the following changes should be made: Get-SecretsVault -> Get-SecretVault Register-SecretsVault -> Register-SecretVault Unregister-SecretsVault -> Unregister-SecretVault