PowerShell / Operation-Validation-Framework

MIT License
225 stars 32 forks source link

PR of pester quiet param fix and usebaicparsing for some pester tests. #29

Closed larssb closed 7 years ago

larssb commented 7 years ago

Description

Fixed the combination of using the OVF -TestFilePath parameter with invoke-pester -quiet or -show. The code, when using the -TestFilePath parameter did not take into consideration the version of Pester and therefore the warning about -Quiet.

While running the Pester tests. Several tests failed as I was using a user through "Runas" while in a Windows user session that is a non-admin user. The "Runas" user does not have IE configured in its profile and therefore the invoke-webrequest cmdlet fails without the -UseBasicParsing parameter. I added that to several tests to avoid this error. Shouldn't be an issue as it is very simple requests via that is tried with invoke-webrequest.

Related Issue

28

Motivation and Context

To get rid of an unnecessary warning. That is already fixed for other parameters in OVF.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Checklist:


This change is Reviewable

devblackops commented 7 years ago

This look good to me @larssb. Thanks!

msftclas commented 7 years ago

CLA assistant check
All CLA requirements met.

larssb commented 7 years ago

Finally signed. I hope it will a breeze to merge it.

@devblackops have a good 1.