PowerShell / PSDscResources

MIT License
129 stars 54 forks source link

Port Style Upgrades in DscResources Folder from xPSDesiredStateConfiguration #162

Closed mhendric closed 5 years ago

mhendric commented 5 years ago

Pull Request (PR) description

Ports most of the style upgrades from xPSDesiredStateConfiguration that have been made in files in the DscResources folder. Among other things, this will help to ensure that the two modules are as in sync as possible, which will in turn help with porting changes and features between modules.

This Pull Request (PR) fixes the following issues

None

Task list


This change is Reviewable

codecov-io commented 5 years ago

Codecov Report

Merging #162 into dev will not change coverage. The diff coverage is 80%.

Impacted file tree graph

@@         Coverage Diff         @@
##            dev   #162   +/-   ##
===================================
  Coverage    83%    83%           
===================================
  Files        19     19           
  Lines      2760   2760           
  Branches      4      4           
===================================
  Hits       2303   2303           
  Misses      453    453           
  Partials      4      4
mhendric commented 5 years ago

Reaching out to the community for help reviewing this one. Would someone be able to help with this?Tagging frequent helpers for awareness: @PlagueHO , @johlju , @tmeckel, and @X-Guardian

PlagueHO commented 5 years ago

I'm on it! Haven't had much time lately.

mhendric commented 5 years ago

Hey @PlagueHO and @johlju , it's a little late, but I just realized that the above decision pretty much kills #140 that @mgreenegit had submitted. I wonder if we should just move his suggested examples to the comment based help. Thoughts?