Closed MJVL closed 8 months ago
I'd be happy to accept it as-is but I am thinking it might be better to expose this allowList as a configurable setting so it can be overridden similar to how we decided to do for this rule when allow-listing az: https://github.com/PowerShell/PSScriptAnalyzer/pull/1846/files#diff-0c1b69454498d51fc5f5ba732f2589578f37357dd80b111e8330fff529036908
I agree, as this could cut down on any future issues asking for additional allowList nouns. I can look into refactoring this as a configurable rule.
For the default value, do you think it would still be proper to include {"Data", "Windows"}
, or would it be better practice to leave this blank entirely?
Yes, in that case also happy to add Windows to default.
Closing and re-opening to re-trigger CI
PR Summary
This PR:
PSUseSingularNouns
to a configurable ruleWindows
to thePSUseSingularNouns
allowlist, closing issue #1736Relevant test has also been added.
PR Checklist
.cs
,.ps1
and.psm1
files have the correct copyright headerWIP:
to the beginning of the title and remove the prefix when the PR is ready.