Fix Failing Unit Tests, Add Integration Tests and update to HQRM

[PlagueHO]

We're wanting to use this module in configs, but at the moment the unit tests are failing and so this would introduce too much risk for us if used in the current state.

After looking through the code it looks like this module could use some TLC to bring it up to current standards and reduce the tech debt.

I'll look at reworking this resource to meet HQRM guidelines over the next few weeks - @kwirkykat - is this OK with you?

The following tasks need to be performed (IMHO):

• [ ] Fix Unit Tests
• [ ] Update unit tests to use standard templates
• [ ] Add Integration Tests
• [ ] Update documentation to meet minimum standards
• [ ] Change references to OneGet to PSGet (?)
• [ ] Convert Localization strings handling to standard folder structure

There will be other tasks required, but these are the basic ones I have identified.

[jianyunt]

Testing failures are caused by NuGet provider regression bug which fails to find-packages from local share.

[kwirkykat]

@PlagueHO This module actually isn't currently part of the DSC Resource Kit (though I would be willing to add it). I think the PowerShell Get/Gallery sister team has ownership over this repository.

The improvements suggested here would be invaluable regardless of whether it's in the res kit or not.

[PlagueHO]

@kwirkykat - Oh right! I had no idea. I guess that explains why it doesn't meet the naming conventions.

TBH our teams use this module extensively. However we do have a guideline that we don't use resources outside the reskit or the Powershell.org ones due to the risk that comes with not having good test coverage or support.

What are the chances of bringing this resource under your umbrella? I'm happy to help out as this is much better than reverting to using xScript. :) and this resource is so awesome! !

[jianyunt]

how about bring it into windows inbox as a part of PackageManagement(OneGet), what do you think?

[PlagueHO]

@jianyunt - I'm definitely OK with it being under PS PackageManagement. My main goal is to make sure there is adequate unit and integration test coverage to control risk. So, whatever is the best plan to enable that. As I said, I'm always happy to commit code if it helps (especially tests :grin:)

[jianyunt]

@PlagueHO, we absolutely appreciate contributions from the Community. BTW, I am fixing these tests in WIP branch. Will PR to master today.

[PlagueHO]

@jianyunt - Awesome! I know the HQRM guidelines the DSC team have created don't apply to this resource module, but they do result reducing risk using a DSC resource. If I were to work on changes to bring this module up to HQRM quality standards at some point, is this something that your team would be interested in?

This wouldn't be for a while yet as I have a significant back log of work on other DSC resources to get through first.

[jianyunt]

@PlagueHO, you are welcome to make the module higher quality. Feel free to send us your PR. thank you!

[brywang-msft]

This issue was moved to OneGet/oneget#253

[jianyunt]

test is fixed.