PowerShell / PowerShell-Snap

MIT License
29 stars 15 forks source link

Please upgrade to `base: core20` #87

Closed xnox closed 2 years ago

xnox commented 2 years ago

Prerequisites

Steps to reproduce

base: core18 is now discouraged with all server snaps having moved onto base: core20.

it will give you access to a newer, Ubuntu 20.04 LTS based runtime, and will minimise install size for end-users, as they will no longer need to pull in core18 whenever they want to use powershell.

Expected behavior

$ snap info --verbose powershell | grep base:
base: core20

Actual behavior

$ snap info --verbose powershell | grep base:
base: core18

Error details

No response

Environment data

I am running Ubuntu

Version

latest/stable

Visuals

No response

lucyllewy commented 2 years ago

@anamnavi this request is not about "compliance", as indicated in your PR (complying with what, exactly?), it's merely about ensuring that PowerShell doesn't drop out of the commitment by Canonical to provide security patches for the libraries that are bundled in the Snap Package that PowerShell is relying upon.

In my opinion it might be worth investigating skipping core20 and jumping directly to core22 if at all possible as this will give Microsoft the longest period of security support for the dependency libraries provided by the Ubuntu archive. This ensures that if future base snap releases (the next one will arrive in 2 years alongside Ubuntu 24.04) cause issues for PowerShell's operation you have a longer period of grace for you to use to fix those issues.

anamnavi commented 2 years ago

@diddledani Thanks for this thorough explanation, I'm still quite new to this project so this context helps! I've updated the PR description to reflect this. As for the suggestion of upgrading to core22 I'll discuss this with the team and update the PR. Thanks!

anamnavi commented 2 years ago

Closing at this is available via stable and preview now, thanks!