search

PowerShell / PowerShell

PowerShell for every system!
https://microsoft.com/PowerShell
MIT License
44.77k stars 7.25k forks source link

Secrets Management should work with the local keychain in macOS #14114

Closed johncwelch closed 3 years ago

johncwelch commented 3 years ago

So looking at the secrets management features, it looks nice, but on macOS, it's a bit...not there. (I know it is very early, and if this is on the list, apologies)

There's no option for Add-Secret Get-SecretVault doesn't seem to know anything about the keychain. This needs to be a default on macOS. Keep in mind, the keychain APIs allow for an arbitrary number of keychains, so if say, one wanted to create just a powershell keychain, that's absolutely possible (along with many other keychain functions): https://developer.apple.com/documentation/security/keychain_services/keychains

this keeps the powershell team from having to write code for their own vaults, and if the user's main keychain is used, then the iCloud sync works as well. This would be a boon to a wide range of powershell users, especially sysadmins.

Enabling the full range of commands for this on macOS is absolutely possible, and is something I've been looking forward to for quite a while (Since talking to Joey Aiello about it at ignite 2019 to be precise.)

rkeithhill commented 3 years ago

Have a look at https://www.powershellgallery.com/packages/SecretManagement.KeyChain/0.1.1

SecretManagement.KeyChain 0.1.1
SecretManagement extension vault for macOS KeyChain

The GitHub project is here: https://github.com/SteveL-MSFT/SecretManagement.KeyChain

johncwelch commented 3 years ago

That's a great addon, but, it's still an addon for a feature that exists in every copy of the macOS. I think it's awesome that Steve did that work, but the OS-provided credentials storage shouldn't require an extension here.

ghost commented 3 years ago

This issue has been marked as external and has not had any activity for 1 day. It has been be closed for housekeeping purposes.