Open MartinGC94 opened 1 year ago
The parameter name should be ExcludeModule
to match existing cmdlets that use Exclude
not Excluded
.
This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author
Queued this up for the WG-Cmdlets to discuss
The Cmdlet WG reviewed this and agree with adding this parameter to Get-Command. We're not making any statement on the quality of this PR.
This PR has 29
quantified lines of changes. In general, a change size of upto 200
lines is ideal for the best PR experience!
Was this comment helpful? :thumbsup: :ok_hand: :thumbsdown: (Email) Customize PullRequestQuantifier for this repository.
This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author
What is the status of this PR?
Hi all. What is the status of this PR?
Hi all again. Just following up. What is the status of this PR?
Sorry to ask again, but what is the status of this PR @iSazonov and @daxian-dbw?
@alanlivio Good news, according to the PS team blogpost: https://devblogs.microsoft.com/powershell/powershell-and-openssh-team-investments-for-2024/ one of the goals for 2024 is to focus on getting community PRs merged. Obviously they haven't started doing that yet, but it would be very weird if they didn't start within the next couple of weeks after making a blog post like that.
PowerShell TeamPlanned team investments for 2024 for PowerShell, OpenSSH, and related tooling.
Good news. I hope that they can merge your PR soon.
This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author
PR Summary
Adds the ExcludeModule parameter to Get-Command so you can exclude commands from specified modules like this:
Get-Command *disk* -ExcludeModule Storage
.PR Context
The main purpose is to contribute towards: https://github.com/PowerShell/PowerShell/issues/16747 but like the previous example shows it can also be useful when manually searching for commands.
PR Checklist
.h
,.cpp
,.cs
,.ps1
and.psm1
files have the correct copyright headerWIP:
or[ WIP ]
to the beginning of the title (theWIP
bot will keep its status check atPending
while the prefix is present) and remove the prefix when the PR is ready.