PowerShell / PowerShell

PowerShell for every system!
https://microsoft.com/PowerShell
MIT License
43.66k stars 7.08k forks source link

Add ExcludeModule parameter to Get-Command #18955

Open MartinGC94 opened 1 year ago

MartinGC94 commented 1 year ago

PR Summary

Adds the ExcludeModule parameter to Get-Command so you can exclude commands from specified modules like this: Get-Command *disk* -ExcludeModule Storage.

PR Context

The main purpose is to contribute towards: https://github.com/PowerShell/PowerShell/issues/16747 but like the previous example shows it can also be useful when manually searching for commands.

PR Checklist

ThomasNieto commented 1 year ago

The parameter name should be ExcludeModule to match existing cmdlets that use Exclude not Excluded.

ghost commented 1 year ago

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days. Maintainer, please provide feedback and/or mark it as Waiting on Author

SteveL-MSFT commented 1 year ago

Queued this up for the WG-Cmdlets to discuss

SteveL-MSFT commented 1 year ago

The Cmdlet WG reviewed this and agree with adding this parameter to Get-Command. We're not making any statement on the quality of this PR.

pull-request-quantifier-deprecated[bot] commented 1 year ago

This PR has 29 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

``` Label : Extra Small Size : +28 -1 Percentile : 11.6% Total files changed: 3 Change summary by file extension: .cs : +25 -1 .ps1 : +3 -0 ``` > Change counts above are quantified counts, based on the [PullRequestQuantifier customizations](https://github.com/microsoft/PullRequestQuantifier/blob/main/docs/prquantifier-yaml.md).

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a balance between between PR complexity and PR review overhead. PRs within the optimal size (typical small, or medium sized PRs) mean: - Fast and predictable releases to production: - Optimal size changes are more likely to be reviewed faster with fewer iterations. - Similarity in low PR complexity drives similar review times. - Review quality is likely higher as complexity is lower: - Bugs are more likely to be detected. - Code inconsistencies are more likely to be detected. - Knowledge sharing is improved within the participants: - Small portions can be assimilated better. - Better engineering practices are exercised: - Solving big problems by dividing them in well contained, smaller problems. - Exercising separation of concerns within the code changes. #### What can I do to optimize my changes - Use the PullRequestQuantifier to quantify your PR accurately - Create a context profile for your repo using the [context generator](https://github.com/microsoft/PullRequestQuantifier/releases) - Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the `Excluded` section from your `prquantifier.yaml` context profile. - Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your `prquantifier.yaml` context profile. - Only use the labels that matter to you, [see context specification](./docs/prquantifier-yaml.md) to customize your `prquantifier.yaml` context profile. - Change your engineering behaviors - For PRs that fall outside of the desired spectrum, review the details and check if: - Your PR could be split in smaller, self-contained PRs instead - Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR). #### How to interpret the change counts in git diff output - One line was added: `+1 -0` - One line was deleted: `+0 -1` - One line was modified: `+1 -1` (git diff doesn't know about modified, it will interpret that line like one addition plus one deletion) - Change percentiles: Change characteristics (addition, deletion, modification) of this PR in relation to all other PRs within the repository.


Was this comment helpful? :thumbsup:  :ok_hand:  :thumbsdown: (Email) Customize PullRequestQuantifier for this repository.

ghost commented 1 year ago

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days. Maintainer, please provide feedback and/or mark it as Waiting on Author

doctordns commented 1 year ago

What is the status of this PR?

alanlivio commented 6 months ago

Hi all. What is the status of this PR?

alanlivio commented 5 months ago

Hi all again. Just following up. What is the status of this PR?

alanlivio commented 4 months ago

Sorry to ask again, but what is the status of this PR @iSazonov and @daxian-dbw?

MartinGC94 commented 3 months ago

@alanlivio Good news, according to the PS team blogpost: https://devblogs.microsoft.com/powershell/powershell-and-openssh-team-investments-for-2024/ one of the goals for 2024 is to focus on getting community PRs merged. Obviously they haven't started doing that yet, but it would be very weird if they didn't start within the next couple of weeks after making a blog post like that.

PowerShell Team
PowerShell and OpenSSH team investments for 2024 - PowerShell Team
Planned team investments for 2024 for PowerShell, OpenSSH, and related tooling.
alanlivio commented 3 months ago

Good news. I hope that they can merge your PR soon.

microsoft-github-policy-service[bot] commented 1 week ago

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days. Maintainer, please provide feedback and/or mark it as Waiting on Author