Discussion issue for IFeedbackProvider on Success Noisy Scenarios

[StevenBucher98]

Summary of the new feature / enhancement

Description

When thinking about having the Feedback Provider of PowerShell be able to trigger on success, per #19372, there is a concern around if this will be very noisy and annoying to users. The basic scenario being that a user runs a command successfully but there is potentially a better way or suggested way to enhance their experience, like the JSON adapter proposition in #19372. This could also be a good way to expose capabilities of PowerShell and nuances to help inform the user about potential ramifications.

Example

Reallocation of array each time for addition:

>$a = @()
>$a += 1
>$a += 2

This works and is successful but a more memory conscious approach would be:

>$a = [System.Collections.ArrayList]::new() 
or
>$a = [System.Collections.Generic.List[object]]::new()

The feedback provider could suggestion something like

>$a = @()
>$a += 1
[suggestion]
  $a is being reallocated each time you append to it, consider defining it as a list:
    -> $a = [System.Collections.ArrayList]::new() 

Proposed technical implementation details (optional)

Questions

The scenarios outlined above begs a lot of questions about the experience of Feedback Providers and if its something the PowerShell engine should step in to ensure "non noisy" behavior or let the feedback providers themselves be responsible for. For contexts feedback providers are developed as extensible PowerShell modules that can be imported.

• Should the feedback providers be left responsible for not being "noisy" to the users?

If left up to the engine:

• How do we classify if something is noisy or not?
• If, after shown at least once after successful, a feedback suggestion is NOT used by the user, then should it be disabled?
• Is there a better way to manage feedback providers besides importing the modules?
• How can we get an indication from the user that feedback is no longer needed on a topic? (i.e dismissal of suggestion)

I am sure I am missing some questions or scenarios but want to open an issue to track these and have a discussion around this concept, any and all feedback is appreciated!

Other related PRs/issues with Feedback Providers

• https://github.com/PowerShell/PowerShell/pull/19133

• 19372

• 19364

• 18852

• https://github.com/PowerShell/PowerShell/issues/19524
• https://github.com/PowerShell/command-not-found

cc @daxian-dbw @SteveL-MSFT @JamesWTruher

[StevenBucher98]

Additional improvements to think about:

• Implement caching utilities to make it easier for developers to utilize it, https://github.com/PowerShell/PowerShell/issues/19660
• Source generator work, reduce boiler plate code https://github.com/PowerShell/PowerShell/issues/19659
• Behavior options for the interface (?)
  • is this in the form of frequency in a given session or somehow check if its in the history - open to feedback

[StevenBucher98]

We potentially we should provide some built in options for reducing the noise but also have a way for feedback providers to overwrite it.

[microsoft-github-policy-service[bot]]

This issue has not had any activity in 6 months, if this is a bug please try to reproduce on the latest version of PowerShell and reopen a new issue and reference this issue if this is still a blocker for you.

[microsoft-github-policy-service[bot]]

This issue has not had any activity in 6 months, if there is no further activity in 7 days, the issue will be closed automatically.

Activity in this case refers only to comments on the issue. If the issue is closed and you are the author, you can re-open the issue using the button below. Please add more information to be considered during retriage. If you are not the author but the issue is impacting you after it has been closed, please submit a new issue with updated details and a link to this issue and the original.