PowerShell / PowerShellEditorServices

A common platform for PowerShell development support in any editor or application!
MIT License
621 stars 211 forks source link

Support Set-PSBreakpoint showing breakpoints in the editor #1091

Open TylerLeonhardt opened 4 years ago

TylerLeonhardt commented 4 years ago

By creating a Proxy function of Set-PSBreakpoint, we can fire the breakpoint event as seen in the DAP spec to notify the client that a breakpoint has been added.

This is the really the final feature needed to provide the "console debugging in PSES experience" that feels totally integrated.

Creating a Proxy cmdlet is easy with:

$Metadata = [System.Management.Automation.CommandMetaData]::new((Get-Command Set-PSBreakpoint))
[System.Management.Automation.ProxyCommand]::Create($Metadata)

Then we'll need a way to give the EditorObject the state of the debugger... but mainly the JsonRpcServer object so that we can use it to send the SendNotification( method to send the breakpoint information to the client.

Then we take that proxy function and add something like:

$psEditor.Components
    .GetService([OmniSharp.Extensions.LanguageServer.Protocol.Server.ILanguageServer])
    .SendNotification("breakpoint", [OmniSharp.Extensions.DebugAdapter.Protocol.Events.BreakpointEvent]::new(<#...#>))

with some error handling and we should be good to go.

SeeminglyScience commented 4 years ago

SMA's Debugger also has a BreakpointUpdated event that might be a little bit more sturdy.