PowerShell / PowerShellEditorServices

A common platform for PowerShell development support in any editor or application!
MIT License
623 stars 214 forks source link

Replace WriteSessionObject code with a Session.Text.Json implementation #1939

Closed pinuke closed 1 year ago

pinuke commented 1 year ago

Summary of the new feature / enhancement

This block of code Serializes JSON by running PowerShell code in C#, which introduces a bug and also introduces bloat. This bug is corrected on Line 138, but it would be better to just use C# in C# use System.Text.Json in this file.

Proposed technical implementation details (optional)

Here is an example of how to use System.Text.Json

I propose that we use features built-in with C# instead of trying to do it with PowerShell

andyleejordan commented 1 year ago

This issue (and your blog posts) are not constructive, please review this community's Code of Conduct before participating in the future. Thank you!

pinuke commented 1 year ago

Apologies. Removing myself, unsubbing, and closing issue.