search

PowerShell / PowerShellEditorServices

A common platform for PowerShell development support in any editor or application!
MIT License
623 stars 214 forks source link

Enable VS Code's shell integration #1958

Closed andyleejordan closed 1 year ago

andyleejordan commented 1 year ago

It seems to work, but needs more testing.

I don't particularly like copy/pasting https://github.com/microsoft/vscode/blob/main/src/vs/workbench/contrib/terminal/browser/media/shellIntegration.ps1 with modifications to embed it, but not sure what else to do here.

Resolves https://github.com/PowerShell/vscode-powershell/issues/3901 along with https://github.com/PowerShell/vscode-powershell/pull/4271.

andyleejordan commented 1 year ago

Per https://github.com/PowerShell/vscode-powershell/issues/3901#issuecomment-1086104834 we may also want a separate setting to enable/disable this just for the Extension Terminal.

andyleejordan commented 1 year ago

@Tyriar hey we got it! Though like I said, I really don't like my copy/paste method, but I'm unsure if anything else is better, we may just have to settle for it.

JustinGrote commented 1 year ago

@andschwa exciting! Looking forward to testing this.