PowerShell / PowerShellEditorServices

A common platform for PowerShell development support in any editor or application!
MIT License
622 stars 213 forks source link

Fix `ShowHelpHandler` by running with `RequiresForeground` #1970

Closed andyleejordan closed 1 year ago

andyleejordan commented 1 year ago

This was broken after the rewrite because we'd forgotten to specify that it needs the foreground (which implies too that it must run immediately). Now the script actually executes, either showing the help in the Extension Terminal (or...I guess nowhere for clients without it) or opening the URL it found. This should still be rewritten properly to return the help over LSP and do something better with it, but at least it's no longer broken.

Fixes https://github.com/PowerShell/vscode-powershell/issues/4212.