search

PowerShell / PowerShellEditorServices

A common platform for PowerShell development support in any editor or application!
MIT License
612 stars 207 forks source link

Replaced WorkspaceFileSystemWrapper with Get-Content and Get-ChildItem #2136

Open dkattan opened 4 months ago

dkattan commented 4 months ago

PR Summary

Removes artificial Uri schema restriction, provides a mechanism for language clients to specify URIs that direct to PSProviders

PR Context

dkattan commented 4 months ago

@andyleejordan Curious your thoughts on this. It ended up being heavier-handed than I wanted with all the async changes, but I'm wondering if that would be desirable if I split it into a separate MR? I know @SeeminglyScience doesn't want me changing the public interfaces, but they likely should've been Task<> from the start, async or not.

SeeminglyScience commented 4 months ago

I know @SeeminglyScience doesn't want me changing the public interfaces, but they likely should've been Task<> from the start, async or not.

Can you talk through what you're trying to solve? When you make a synchronous method return Task<> all you're really doing is requiring wrapper object be created that will be immediately discarded. It doesn't change the behavior at all if that's the assumption.