search

PowerShell / PowerShellEditorServices

A common platform for PowerShell development support in any editor or application!
MIT License
634 stars 217 forks source link

VIM E2E Test Broken by VIM Ubuntu Package 8.2.3995-1ubuntu2.19 #2182

Open JustinGrote opened 1 month ago

JustinGrote commented 1 month ago

https://github.com/PowerShell/PowerShellEditorServices/actions/runs/11132769096/job/30937371296?pr=2152

JustinGrote commented 1 month ago

Test works fine in upterm, weird. What context is different in the run env I wonder? image

JustinGrote commented 1 month ago

@andyleejordan I think whatever VIM you're downloading, something in the latest version broke the tests. If I remove the ENV to the executable, the test completes, see this PR: https://github.com/PowerShell/PowerShellEditorServices/pull/2183

JustinGrote commented 1 month ago

Looks like package updated to vim-gtk3 8.2.3995-1ubuntu2.19, it was ubuntu2.18 before, something in that update appears to have broken it. https://launchpad.net/ubuntu/+source/vim/2:8.2.3995-1ubuntu2.19

JustinGrote commented 1 month ago

@andyleejordan nightly works fine, so I adjusted the github action to use nightly, see this PR: https://github.com/PowerShell/PowerShellEditorServices/pull/2183

We will need to actually verify if the extension is actually broken due to this security update package, since it is the current stable ubuntu package and will have widespread usage, and determine if it's something with us or with vim or their lsp client (it's not clear from the test)

andyleejordan commented 1 month ago

Yay for fun new bugs.