search

PowerShell / PowerShellStandard

MIT License
158 stars 24 forks source link

Can't override PrivateData or PSHostUserInterface.SupportsVirtualTerminal #15

Closed TylerLeonhardt closed 5 years ago

TylerLeonhardt commented 6 years ago

Attempted to port PowerShell Editor Services to PSStandard today just to try and ran into these errors:

Session/Host/EditorServicesPSHost.cs(83,34): error CS0506: 'EditorServicesPSHost.PrivateData': cannot override inherited member 'PSHost.PrivateData' because it is not marked virtual, abstract, or override [/Users/tylerleonhardt/Desktop/Tech/PowerShell/vscode/PowerShellEditorServices/src/PowerShellEditorServices/PowerShellEditorServices.csproj] Session/Host/EditorServicesPSHostUserInterface.cs(71,30): error CS0506: 'EditorServicesPSHostUserInterface.SupportsVirtualTerminal': cannot override inherited member 'PSHostUserInterface.SupportsVirtualTerminal' because it is not marked virtual, abstract, or override [/Users/tylerleonhardt/Desktop/Tech/PowerShell/vscode/PowerShellEditorServices/src/PowerShellEditorServices/PowerShellEditorServices.csproj]

Here's the line for the first error: https://github.com/PowerShell/PowerShellEditorServices/blob/master/src/PowerShellEditorServices/Session/Host/EditorServicesPSHost.cs#L83

And second: https://github.com/PowerShell/PowerShellEditorServices/blob/master/src/PowerShellEditorServices/Session/Host/EditorServicesPSHostUserInterface.cs#L71

Is there another way to approach this or is this an issue with PowerShellStandard?

JamesWTruher commented 6 years ago

it's a bug in the standard library - I'm working on a fix

JamesWTruher commented 5 years ago

fixed in RC1 (or earlier)