search

PowerShell / PowerShellStandard

MIT License
158 stars 24 forks source link

WIP: Update template to use PSL 5.1.0 #66

Closed rkeithhill closed 5 years ago

rkeithhill commented 5 years ago

There are a few things that need to be worked out here. There was a PR merged by @JamesWTruher back in March that updated parts of the template for use of PSL 5.1.1. But I don't see a 5.1.1 version on nuget.org. The latest there is 5.1.0.

Also, I installed the template today and the project it scaffolded for me was still using 5.1.0-preview-06. So I think we need an update to move to 5.1.0 or perhaps 5.1.1 when it gets published to nuget.org.

I updated the generated module manifest copyright to 2019 and added code-block language specifiers in the README.md file to eliminate the markdownlint warnings I was getting.

rkeithhill commented 5 years ago

Also, the README.md refers to 5.1.1:

Options:
  -v|--powershell-standard-version
                                        5.1.1               - PowerShell Standard 5.1.1

So if this PR were to go through using 5.1.0, I'll need to update the README to refer to 5.1.0.

TylerLeonhardt commented 5 years ago

AFAIK, a 5.1.1 isn't happening any time soon so lets go with 5.1.0. Can you update the README to refer to 5.1.0?

rkeithhill commented 5 years ago

Sure, I'll do that tonight.

JamesWTruher commented 5 years ago

The changes found in b69d5e6a5107287a5981db515bae4d5631278f76 added a net452 assembly, along with a number of other additions, but somehow was unreleased. I'll take this PR, but produce another PR to push the version everywhere to 5.1.1. I'm uncomfortable with doing another release without updating the release number

rkeithhill commented 5 years ago

Works for me. Thanks!