search

PowerShell / PrivateCloud.DiagnosticInfo

MIT License
39 stars 40 forks source link

fail to get SmbLocalization.psd1 when Culture not en-US #157

Open fmata-afk-zz opened 4 years ago

fmata-afk-zz commented 4 years ago

When running the module on a environment with culture en-GB (can be checked with Get-Culture) the script fails to get SMB info on SmbLocalization.psd1 The path C:\Windows\system32\WindowsPowerShell\v1.0\Modules\SmbShare\en-GB doens´t exist under module only the en-US.

dl2n commented 4 years ago

Sounds like an SMB module localization bug. Can you cut/paste the exact error message you received, and does this prevent generating the triage package entirely or is it limited to the SMB data within it?

Viswanath, can you confirm/redirect? Workaround?

Sent from Mailhttps://go.microsoft.com/fwlink/?LinkId=550986 for Windows 10

From: fmata-afkmailto:notifications@github.com Sent: Tuesday, August 4, 2020 02:48 To: PowerShell/PrivateCloud.DiagnosticInfomailto:PrivateCloud.DiagnosticInfo@noreply.github.com Cc: Subscribedmailto:subscribed@noreply.github.com Subject: [PowerShell/PrivateCloud.DiagnosticInfo] fail to get SmbLocalization.psd1 when Culture not en-US (#157)

When running the module on a environment with culture en-GB (can be checked with Get-Culture) the script fails to get SMB info on SmbLocalization.psd1 The path C:\Windows\system32\WindowsPowerShell\v1.0\Modules\SmbShare\en-GB doens´t exist under module only the en-US.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FPowerShell%2FPrivateCloud.DiagnosticInfo%2Fissues%2F157&data=02%7C01%7C%7C686b96d013df4229703808d8385b88d2%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637321313065072163&sdata=N%2BiIYpL8dcBLfhP4K%2BKD6hJFjnXkj6%2BSarb1pBdhXD4%3D&reserved=0, or unsubscribehttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FACCWSKIMXEBRCERL27IWBADR67KOTANCNFSM4PUG4YLQ&data=02%7C01%7C%7C686b96d013df4229703808d8385b88d2%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637321313065082157&sdata=2yhbu2vxGGvwvZZRJ3sp7dECVziD7q8cqo%2FEiabrye4%3D&reserved=0.

visvel commented 4 years ago

I am not very familiar with the localization side changes. @Amithmailto:Amith.Kamath@microsoft.com any idea on the smb module localization or anyone?

~Viswanath

From: Dan Lovinger notifications@github.com Sent: Tuesday, August 4, 2020 12:25 PM To: PowerShell/PrivateCloud.DiagnosticInfo PrivateCloud.DiagnosticInfo@noreply.github.com Cc: Subscribed subscribed@noreply.github.com Subject: Re: [PowerShell/PrivateCloud.DiagnosticInfo] fail to get SmbLocalization.psd1 when Culture not en-US (#157)

Sounds like an SMB module localization bug. Can you cut/paste the exact error message you received, and does this prevent generating the triage package entirely or is it limited to the SMB data within it?

Viswanath, can you confirm/redirect? Workaround?

Sent from Mailhttps://go.microsoft.com/fwlink/?LinkId=550986 for Windows 10

From: fmata-afkmailto:notifications@github.com Sent: Tuesday, August 4, 2020 02:48 To: PowerShell/PrivateCloud.DiagnosticInfomailto:PrivateCloud.DiagnosticInfo@noreply.github.com Cc: Subscribedmailto:subscribed@noreply.github.com Subject: [PowerShell/PrivateCloud.DiagnosticInfo] fail to get SmbLocalization.psd1 when Culture not en-US (#157)

When running the module on a environment with culture en-GB (can be checked with Get-Culture) the script fails to get SMB info on SmbLocalization.psd1 The path C:\Windows\system32\WindowsPowerShell\v1.0\Modules\SmbShare\en-GB doens´t exist under module only the en-US.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FPowerShell%2FPrivateCloud.DiagnosticInfo%2Fissues%2F157&data=02%7C01%7C%7C686b96d013df4229703808d8385b88d2%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637321313065072163&sdata=N%2BiIYpL8dcBLfhP4K%2BKD6hJFjnXkj6%2BSarb1pBdhXD4%3D&reserved=0, or unsubscribehttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FACCWSKIMXEBRCERL27IWBADR67KOTANCNFSM4PUG4YLQ&data=02%7C01%7C%7C686b96d013df4229703808d8385b88d2%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637321313065082157&sdata=2yhbu2vxGGvwvZZRJ3sp7dECVziD7q8cqo%2FEiabrye4%3D&reserved=0.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FPowerShell%2FPrivateCloud.DiagnosticInfo%2Fissues%2F157%23issuecomment-668780666&data=02%7C01%7Cvisvel%40microsoft.com%7Cbf1954cd78da410dd7ab08d838ac1f3f%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637321659193429081&sdata=CugeaDpMuK2TuGByqU61YBHP1MQxZgxZFgFW5VnbKWI%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FADUBHLQ4IRK5K6VMKE4A4NTR7BOB3ANCNFSM4PUG4YLQ&data=02%7C01%7Cvisvel%40microsoft.com%7Cbf1954cd78da410dd7ab08d838ac1f3f%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637321659193429081&sdata=NWWLPr2X0mWv6s1G41s2nrw7VP%2Bz7GWpTKQ8dlw5R9Y%3D&reserved=0.

dl2n commented 4 years ago

Viswanath, please check with Vladimir (SMB Lead).

Lets get the specific error first.

Sent from Mailhttps://go.microsoft.com/fwlink/?LinkId=550986 for Windows 10

From: visvelmailto:notifications@github.com Sent: Tuesday, August 4, 2020 13:02 To: PowerShell/PrivateCloud.DiagnosticInfomailto:PrivateCloud.DiagnosticInfo@noreply.github.com Cc: Dan Lovingermailto:dl2n@outlook.com; Commentmailto:comment@noreply.github.com Subject: Re: [PowerShell/PrivateCloud.DiagnosticInfo] fail to get SmbLocalization.psd1 when Culture not en-US (#157)

I am not very familiar with the localization side changes. @Amithmailto:Amith.Kamath@microsoft.com any idea on the smb module localization or anyone?

~Viswanath

From: Dan Lovinger notifications@github.com Sent: Tuesday, August 4, 2020 12:25 PM To: PowerShell/PrivateCloud.DiagnosticInfo PrivateCloud.DiagnosticInfo@noreply.github.com Cc: Subscribed subscribed@noreply.github.com Subject: Re: [PowerShell/PrivateCloud.DiagnosticInfo] fail to get SmbLocalization.psd1 when Culture not en-US (#157)

Sounds like an SMB module localization bug. Can you cut/paste the exact error message you received, and does this prevent generating the triage package entirely or is it limited to the SMB data within it?

Viswanath, can you confirm/redirect? Workaround?

Sent from Mailhttps://go.microsoft.com/fwlink/?LinkId=550986 for Windows 10

From: fmata-afkmailto:notifications@github.com Sent: Tuesday, August 4, 2020 02:48 To: PowerShell/PrivateCloud.DiagnosticInfomailto:PrivateCloud.DiagnosticInfo@noreply.github.com Cc: Subscribedmailto:subscribed@noreply.github.com Subject: [PowerShell/PrivateCloud.DiagnosticInfo] fail to get SmbLocalization.psd1 when Culture not en-US (#157)

When running the module on a environment with culture en-GB (can be checked with Get-Culture) the script fails to get SMB info on SmbLocalization.psd1 The path C:\Windows\system32\WindowsPowerShell\v1.0\Modules\SmbShare\en-GB doens´t exist under module only the en-US.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FPowerShell%2FPrivateCloud.DiagnosticInfo%2Fissues%2F157&data=02%7C01%7C%7C686b96d013df4229703808d8385b88d2%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637321313065072163&sdata=N%2BiIYpL8dcBLfhP4K%2BKD6hJFjnXkj6%2BSarb1pBdhXD4%3D&reserved=0, or unsubscribehttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FACCWSKIMXEBRCERL27IWBADR67KOTANCNFSM4PUG4YLQ&data=02%7C01%7C%7C686b96d013df4229703808d8385b88d2%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637321313065082157&sdata=2yhbu2vxGGvwvZZRJ3sp7dECVziD7q8cqo%2FEiabrye4%3D&reserved=0.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FPowerShell%2FPrivateCloud.DiagnosticInfo%2Fissues%2F157%23issuecomment-668780666&data=02%7C01%7Cvisvel%40microsoft.com%7Cbf1954cd78da410dd7ab08d838ac1f3f%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637321659193429081&sdata=CugeaDpMuK2TuGByqU61YBHP1MQxZgxZFgFW5VnbKWI%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FADUBHLQ4IRK5K6VMKE4A4NTR7BOB3ANCNFSM4PUG4YLQ&data=02%7C01%7Cvisvel%40microsoft.com%7Cbf1954cd78da410dd7ab08d838ac1f3f%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637321659193429081&sdata=NWWLPr2X0mWv6s1G41s2nrw7VP%2Bz7GWpTKQ8dlw5R9Y%3D&reserved=0.

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FPowerShell%2FPrivateCloud.DiagnosticInfo%2Fissues%2F157%23issuecomment-668797230&data=02%7C01%7C%7Cad73d5f5671f4d73a86f08d838b15511%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637321681564376419&sdata=cNQeWL3m3dSTM5aKdo2Dn%2F%2BegZ%2BUSl%2BE3BYFg8v8rrc%3D&reserved=0, or unsubscribehttps://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FACCWSKJ3ZBBU67AGXIKEOP3R7BSNXANCNFSM4PUG4YLQ&data=02%7C01%7C%7Cad73d5f5671f4d73a86f08d838b15511%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637321681564386416&sdata=EyNzOn4ePzRV%2F50%2FD6c0jfrrLHx8FdHHd0mUMhc6ADg%3D&reserved=0.

visvel commented 4 years ago

Sure Dan. @fmata-afk Can you please detail on the error?

fmata-afk-zz commented 4 years ago

Hello,

What we get below. We fail because the path 'C:\Windows\system32\WindowsPowerShell\v1.0\Modules\SmbShare\en-GB don’t exist. Only the en-US folder is present on this module.

28 2020-08-04T10:27:06 : Start gather of verifier ... 29 Cannot find the Windows PowerShell data file 'SmbLocalization.psd1' in directory 30 'C:\Windows\system32\WindowsPowerShell\v1.0\Modules\SmbShare\en-GB\', or in any parent culture directories. 31 + CategoryInfo : ObjectNotFound: (C:\Windows\syst...calization.psd1:String) [Import-LocalizedData], 32 PSInvalidOperationException 33 + FullyQualifiedErrorId : ImportLocalizedData,Microsoft.PowerShell.Commands.ImportLocalizedData 34 + PSComputerName : HS2DENGSTO107 35 Cannot find the Windows PowerShell data file 'SmbLocalization.psd1' in directory

Best Regards,

Fernando Mata

Support Escalation Engineer Windows Core Customer Service and Support Phone : +351 210 602 149 24 x 7 Support: +351 808 22 32 42 Working Hours: Mon-Fri 09/18h GMT+1

[cid:image001.png@01D66B12.CEB54D60] If you have any feedback about my work, please let either myself or my manager Mihaela Diana available at MihaelaDiana.Radulescu@microsoft.commailto:MihaelaDiana.Radulescu@microsoft.com

From: visvel notifications@github.com Sent: Tuesday, August 4, 2020 10:53 PM To: PowerShell/PrivateCloud.DiagnosticInfo PrivateCloud.DiagnosticInfo@noreply.github.com Cc: Fernando Mata Fernando.Mata@microsoft.com; Mention mention@noreply.github.com Subject: Re: [PowerShell/PrivateCloud.DiagnosticInfo] fail to get SmbLocalization.psd1 when Culture not en-US (#157)

Sure Dan. @fmata-afkhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Ffmata-afk&data=02%7C01%7CFernando.Mata%40microsoft.com%7C06edfd1af242474ba1cb08d838c0c5bf%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637321747889517475&sdata=f85LNUKOFI09DFkJ0hNuvlzFc%2Bxt0ShUdeZj%2FLpeD8s%3D&reserved=0 Can you please detail on the error?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FPowerShell%2FPrivateCloud.DiagnosticInfo%2Fissues%2F157%23issuecomment-668843261&data=02%7C01%7CFernando.Mata%40microsoft.com%7C06edfd1af242474ba1cb08d838c0c5bf%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637321747889517475&sdata=6arvZBlgO6L9QR1w8eLPFN6DHFaH6kjOG5v0wmdYvWI%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAOK6D2XJYXUFI4H6XXJGACDR7B7MHANCNFSM4PUG4YLQ&data=02%7C01%7CFernando.Mata%40microsoft.com%7C06edfd1af242474ba1cb08d838c0c5bf%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637321747889527469&sdata=N%2FxTmYCXJJdLxnpNo8DVhFISwLgnP8w2vVMYY7RDZkQ%3D&reserved=0.

visvel commented 4 years ago

Upon reaching out to SMB team they seem to believes the issue is due to the en-GB langpack not installed. From https://docs.microsoft.com/en-us/windows-hardware/manufacture/desktop/add-language-packs-to-windows it seems to be specific to client os. Let me know if you are able to look to see on the langpack.

fmata-afk-zz commented 4 years ago

Hi,

This was happening on a Windows Server 2019. To run the module on non en-US we need to install the language pack? I have been using this module on several Europe customers for a while an didn´t notice it before.

From: visvel notifications@github.com Sent: Wednesday, August 5, 2020 9:25 PM To: PowerShell/PrivateCloud.DiagnosticInfo PrivateCloud.DiagnosticInfo@noreply.github.com Cc: Fernando Mata Fernando.Mata@microsoft.com; Mention mention@noreply.github.com Subject: Re: [PowerShell/PrivateCloud.DiagnosticInfo] fail to get SmbLocalization.psd1 when Culture not en-US (#157)

Upon reaching out to SMB team they seem to believes the issue is due to the en-GB langpack not installed. From https://docs.microsoft.com/en-us/windows-hardware/manufacture/desktop/add-language-packs-to-windowshttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdocs.microsoft.com%2Fen-us%2Fwindows-hardware%2Fmanufacture%2Fdesktop%2Fadd-language-packs-to-windows&data=02%7C01%7CFernando.Mata%40microsoft.com%7Cc2a367d544ee475070b508d8397da08c%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637322559025136104&sdata=%2FBtggV26DvU1UTSSz5Asm0YGHYSWems7VwmOIFPwls4%3D&reserved=0 link it seems to be specific to client os.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FPowerShell%2FPrivateCloud.DiagnosticInfo%2Fissues%2F157%23issuecomment-669484266&data=02%7C01%7CFernando.Mata%40microsoft.com%7Cc2a367d544ee475070b508d8397da08c%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637322559025136104&sdata=WOI2h29uLl87VZ528ZBaQ1iw2XOsPfBRec3g2412HTs%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAOK6D2XNCKKOJCOOREHFWB3R7G5ZXANCNFSM4PUG4YLQ&data=02%7C01%7CFernando.Mata%40microsoft.com%7Cc2a367d544ee475070b508d8397da08c%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637322559025146061&sdata=hmB1mICI8qLqsLD0ttmOLrQjWhN444H%2F0CBKDncfTwQ%3D&reserved=0.

visvel commented 4 years ago

Hi, I do not believe we need to install explicitly (to your question "To run the module on non en-US we need to install the language pack?"). @Vladimirmailto:vpetter@microsoft.com I think would be the best to comment on this issue (detailed below).

~Viswanath.

From: fmata-afk notifications@github.com Sent: Thursday, August 6, 2020 2:17 AM To: PowerShell/PrivateCloud.DiagnosticInfo PrivateCloud.DiagnosticInfo@noreply.github.com Cc: Viswanath Vellaiappan visvel@microsoft.com; Comment comment@noreply.github.com Subject: Re: [PowerShell/PrivateCloud.DiagnosticInfo] fail to get SmbLocalization.psd1 when Culture not en-US (#157)

Hi,

This was happening on a Windows Server 2019. To run the module on non en-US we need to install the language pack? I have been using this module on several Europe customers for a while an didn´t notice it before.

From: visvel notifications@github.com Sent: Wednesday, August 5, 2020 9:25 PM To: PowerShell/PrivateCloud.DiagnosticInfo PrivateCloud.DiagnosticInfo@noreply.github.com Cc: Fernando Mata Fernando.Mata@microsoft.com; Mention mention@noreply.github.com Subject: Re: [PowerShell/PrivateCloud.DiagnosticInfo] fail to get SmbLocalization.psd1 when Culture not en-US (#157)

Upon reaching out to SMB team they seem to believes the issue is due to the en-GB langpack not installed. From https://docs.microsoft.com/en-us/windows-hardware/manufacture/desktop/add-language-packs-to-windowshttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdocs.microsoft.com%2Fen-us%2Fwindows-hardware%2Fmanufacture%2Fdesktop%2Fadd-language-packs-to-windows&data=02%7C01%7CFernando.Mata%40microsoft.com%7Cc2a367d544ee475070b508d8397da08c%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637322559025136104&sdata=%2FBtggV26DvU1UTSSz5Asm0YGHYSWems7VwmOIFPwls4%3D&reserved=0 link it seems to be specific to client os.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FPowerShell%2FPrivateCloud.DiagnosticInfo%2Fissues%2F157%23issuecomment-669484266&data=02%7C01%7CFernando.Mata%40microsoft.com%7Cc2a367d544ee475070b508d8397da08c%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637322559025136104&sdata=WOI2h29uLl87VZ528ZBaQ1iw2XOsPfBRec3g2412HTs%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAOK6D2XNCKKOJCOOREHFWB3R7G5ZXANCNFSM4PUG4YLQ&data=02%7C01%7CFernando.Mata%40microsoft.com%7Cc2a367d544ee475070b508d8397da08c%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637322559025146061&sdata=hmB1mICI8qLqsLD0ttmOLrQjWhN444H%2F0CBKDncfTwQ%3D&reserved=0.

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FPowerShell%2FPrivateCloud.DiagnosticInfo%2Fissues%2F157%23issuecomment-669813694&data=02%7C01%7Cvisvel%40microsoft.com%7C3b75d694c3424fab435b08d839e97fc6%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637323022319937871&sdata=BppTYBfjWDMHJiZdwRhMULgmVVUyre471Yr4niPLSd0%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FADUBHLXZ4A6Z3R23O5MSD7DR7JYJNANCNFSM4PUG4YLQ&data=02%7C01%7Cvisvel%40microsoft.com%7C3b75d694c3424fab435b08d839e97fc6%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637323022319947863&sdata=tixT8nrv5Dg1gTdaPMZ6kB%2BBSniQBDuKEMdkfV5LM1A%3D&reserved=0.

visvel commented 4 years ago

Aslo want to bring it for awareness, as Taylor pointed it would be good to check Get-WinUserLanguageList output (below is what I see in my setup),

PS C:\Windows\system32> get-WinUserLanguageList

LanguageTag : en-US Autonym : English (United States) EnglishName : English LocalizedName : English (United States) ScriptName : Latin InputMethodTips : {0409:00000409} Spellchecking : True Handwriting : False

~Viswanath

From: Viswanath Vellaiappan visvel@microsoft.com Sent: Thursday, August 6, 2020 1:18 PM To: PowerShell/PrivateCloud.DiagnosticInfo PrivateCloud.DiagnosticInfo@noreply.github.com; PowerShell/PrivateCloud.DiagnosticInfo reply@reply.github.com; Vladimir Petter vpetter@microsoft.com; Dan Lovinger danlo@microsoft.com; Taylor Hope tayloh@microsoft.com Cc: Comment comment@noreply.github.com Subject: Re: [PowerShell/PrivateCloud.DiagnosticInfo] fail to get SmbLocalization.psd1 when Culture not en-US (#157)

Hi, I do not believe we need to install explicitly (to your question "To run the module on non en-US we need to install the language pack?"). @Vladimirmailto:vpetter@microsoft.com I think would be the best to comment on this issue (detailed below).

~Viswanath.

From: fmata-afk notifications@github.com Sent: Thursday, August 6, 2020 2:17 AM To: PowerShell/PrivateCloud.DiagnosticInfo PrivateCloud.DiagnosticInfo@noreply.github.com Cc: Viswanath Vellaiappan visvel@microsoft.com; Comment comment@noreply.github.com Subject: Re: [PowerShell/PrivateCloud.DiagnosticInfo] fail to get SmbLocalization.psd1 when Culture not en-US (#157)

Hi,

This was happening on a Windows Server 2019. To run the module on non en-US we need to install the language pack? I have been using this module on several Europe customers for a while an didn´t notice it before.

From: visvel notifications@github.com Sent: Wednesday, August 5, 2020 9:25 PM To: PowerShell/PrivateCloud.DiagnosticInfo PrivateCloud.DiagnosticInfo@noreply.github.com Cc: Fernando Mata Fernando.Mata@microsoft.com; Mention mention@noreply.github.com Subject: Re: [PowerShell/PrivateCloud.DiagnosticInfo] fail to get SmbLocalization.psd1 when Culture not en-US (#157)

Upon reaching out to SMB team they seem to believes the issue is due to the en-GB langpack not installed. From https://docs.microsoft.com/en-us/windows-hardware/manufacture/desktop/add-language-packs-to-windowshttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdocs.microsoft.com%2Fen-us%2Fwindows-hardware%2Fmanufacture%2Fdesktop%2Fadd-language-packs-to-windows&data=02%7C01%7CFernando.Mata%40microsoft.com%7Cc2a367d544ee475070b508d8397da08c%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637322559025136104&sdata=%2FBtggV26DvU1UTSSz5Asm0YGHYSWems7VwmOIFPwls4%3D&reserved=0 link it seems to be specific to client os.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FPowerShell%2FPrivateCloud.DiagnosticInfo%2Fissues%2F157%23issuecomment-669484266&data=02%7C01%7CFernando.Mata%40microsoft.com%7Cc2a367d544ee475070b508d8397da08c%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637322559025136104&sdata=WOI2h29uLl87VZ528ZBaQ1iw2XOsPfBRec3g2412HTs%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAOK6D2XNCKKOJCOOREHFWB3R7G5ZXANCNFSM4PUG4YLQ&data=02%7C01%7CFernando.Mata%40microsoft.com%7Cc2a367d544ee475070b508d8397da08c%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637322559025146061&sdata=hmB1mICI8qLqsLD0ttmOLrQjWhN444H%2F0CBKDncfTwQ%3D&reserved=0.

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FPowerShell%2FPrivateCloud.DiagnosticInfo%2Fissues%2F157%23issuecomment-669813694&data=02%7C01%7Cvisvel%40microsoft.com%7C3b75d694c3424fab435b08d839e97fc6%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637323022319937871&sdata=BppTYBfjWDMHJiZdwRhMULgmVVUyre471Yr4niPLSd0%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FADUBHLXZ4A6Z3R23O5MSD7DR7JYJNANCNFSM4PUG4YLQ&data=02%7C01%7Cvisvel%40microsoft.com%7C3b75d694c3424fab435b08d839e97fc6%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637323022319947863&sdata=tixT8nrv5Dg1gTdaPMZ6kB%2BBSniQBDuKEMdkfV5LM1A%3D&reserved=0.

DennisL68 commented 2 years ago

This will fail even when running on an en-US combo of Windows 10 getting the module from Windows 2019 Server using WinRM. 

>[environment]::OSVersion.Version

Major  Minor  Build  Revision
-----  -----  -----  --------
10     0      17763  0

>Get-Culture

LCID             Name             DisplayName
----             ----             -----------
1033             en-US            English (United States)

>$PSVersionTable

Name                           Value
----                           -----
PSVersion                      5.1.17763.2931
PSEdition                      Desktop
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   10.0.17763.2931
CLRVersion                     4.0.30319.42000
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1
>[environment]::OSVersion.Version

Major  Minor  Build  Revision
-----  -----  -----  --------
10     0      19043  0

>Get-Culture

LCID             Name             DisplayName
----             ----             -----------
1033             en-US            English (United States)

>$PSVersionTable

Name                           Value
----                           -----
PSVersion                      5.1.19041.1682
PSEdition                      Desktop
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   10.0.19041.1682
CLRVersion                     4.0.30319.42000
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1
>$dc = New-PSSession -ComputerName DC

>Import-Module -PSSession $dc -Name SMBShare -Prefix DC

Import-Module : Failure from remote command: Import-Module -Name 'SMBShare': Cannot find the Windows PowerShell data
file 'SmbLocalization.psd1' in directory 'C:\Windows\system32\WindowsPowerShell\v1.0\Modules\SMBShare\en-GB\', or in
any parent culture directories.
At line:1 char:1
+ Import-Module -PSSession $dc -Name SMBShare -Prefix DC
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : ObjectNotFound: (C:\Windows\syst...calization.psd1:String) [Import-LocalizedData], PSInv
   alidOperationException
    + FullyQualifiedErrorId : ImportLocalizedData,Microsoft.PowerShell.Commands.ImportLocalizedData

For now, I just duplicated the folder en-US to en-GB on the server as a workaround...

logicalextreme commented 1 week ago

Still getting this issue 4 years later. What's weird is that on two different machines I've had no issues when initially using SmbShare cmdlets, then this bug started happening after a reboot. ¯_(ツ)_/¯

I don't consider changing CurrentUICulture to en-US or manually creating a (in my case) en-GB directory under the PS5 modules directory to be a fix, but appreciate that this is something the Windows PS team need to address. For now I've gone with duplicating the directory, but that's only going to work on my machines.