search

PowerShell / SecretManagement

PowerShell module to consistent usage of secrets through different extension vaults
MIT License
335 stars 47 forks source link

`Set-DefaultVault` doesn't have the same prefix as other cmdlets #79

Closed TylerLeonhardt closed 3 years ago

TylerLeonhardt commented 4 years ago

It's best practice for a module to have the same prefix for every cmdlet in a module so that users know that a cmdlet comes from a module... Or use a prefix that gives context to the user on what they are doing.

Set-DefaultVault doesn't have the prefix that the others do and I worry that it could stomp on an existing cmdlet since Vault is fairly overloaded in the key store space.

This cmdlet should either be Set-SecretDefaultVault or Set-SecretVaultDefault.

itfranck commented 4 years ago

My vote to the latter (Set-SecretVaultDefault). It feels more aligned with other vault operations (Test-SecretVault / Register-SecretVault / UnregisterSecretVault)

PaulHigin commented 3 years ago

Changed for 1.0 RC1 release.