Unregister-SecretVault should be ConfirmImpact "High"

PowerShell / SecretManagement

PowerShell module to consistent usage of secrets through different extension vaults

MIT License

320 stars 46 forks source link

Unregister-SecretVault should be ConfirmImpact "High" #94

Open JustinGrote opened 3 years ago

JustinGrote commented 3 years ago

It is common a user may be pipelining unregistrations, so commands like Get-SecretVault | Unregister-SecretVault which can unregister a ton of vaults should not be allowed to happen without at least some sort of confirmation

SydneyhSmith commented 3 years ago

Thanks @JustinGrote we made this choice to follow the pattern of other Unregister cmdlets in PowerShell (like scheduled jobs), and because it does not necessarily remove the underlying vault, however we will leave this open for discussion