PowerShell / Win32-OpenSSH

Win32 port of OpenSSH
7.43k stars 760 forks source link

Binaries for 8.1.0.0 ? #1578

Open DarwinJS opened 4 years ago

DarwinJS commented 4 years ago

The binaries for 8.1.0-Beta1 were packaged in chocolatey based on being made available here.

Now it seems 8.1.0.0 is released, but binaries are not built by openssh-portable. (https://github.com/PowerShell/Win32-OpenSSH/releases).

Is it possible to get the binaries for 8.1.0.0 here or are they available elsewhere?

musm commented 4 years ago

cc @manojampalam @bagajjal

bagajjal commented 4 years ago

@DarwinJS - Are you referring to https://github.com/PowerShell/Win32-OpenSSH/releases/tag/v8.1.0.0p1-Beta.

If yes, why do you suspect these are not built by openssh-portable?

DarwinJS commented 4 years ago

The confusion is with a prerelease being the latest available binaries here in this repo "v8.1.0.p1-beta" and a full release "v8.1.0.0" on openssh-portable for the source code.

musm commented 4 years ago

@DarwinJS aren't the binaries you want located here: https://github.com/PowerShell/Win32-OpenSSH/releases ?

jborean93 commented 4 years ago

It sounds like this is just a mismatch on version info from the binaries here and the binaries on the Windows optional feature with the Windows optional feature just omitting the beta part. Are the hash's the same with the one located on GitHub?

bagajjal commented 4 years ago

@DarwinJS - I just followed the previous convention. openssh-portable has release name without "p1-beta" as opposed to win32-openssh but they meant same.

@jborean93 - The binaries shipped in windows are onecore binaries (work on all windows SKUs) where as github binaries are desktop binaries. The source code is same if the version is same.

We use the last part of version for windows releases when we deviate from github release. For github releases the last part of version is always 0.

jborean93 commented 4 years ago

@bagajjal why the divergance in releases, the code may be the same but why not just ship the onecore binaries for both and keep the version numbers the same, will remove the confusion. Is the onecore version not used in GitHub for backwards compatibility with older OS versions that Windows doesn't ship SSH as an optional feature to?

bagajjal commented 4 years ago

version numbers will differ only when there is a code difference between windows and github versions. The divergence comes where there are security bugs (or) release timelines between windows & github doesn't align and we have to take some mandatory fixes into windows release.

DarwinJS commented 4 years ago

@bagajjal - this seems very confusing.

Even if the versions needed to be different for some odd reason, it seems unusual to call it beta if it is really a production-grade release?

Wouldn't something like 8.1.0-desktop.0 be better?

musm commented 4 years ago

There's still an issue with the binaries uploaded to chocolatey they report an older version and in fact don't work with passphrase protected keys.

Reinstalling with the ones posted on github by microsoft fixed this issue (ssh -Version also reports the correct version 8.1)

WSLUser commented 4 years ago

Even if the versions needed to be different for some odd reason, it seems unusual to call it beta if it is really a production-grade release?

I wouldn't consider it production ready until this PR is merged: https://github.com/PowerShell/openssh-portable/pull/362 and https://github.com/PowerShell/Win32-OpenSSH/issues/1322 is resolved.

bagajjal commented 4 years ago

Assigning to @maertendMSFT (OpenSSH PM) to finalize on the naming convention.

DarwinJS commented 4 years ago

@bagajjal - If it not officially released yet - why is there a release with a non-prerelease sem version here: https://github.com/PowerShell/openssh-portable/releases/tag/v8.1.0.0

bagajjal commented 4 years ago

@DarwinJS - https://github.com/PowerShell/openssh-portable/releases is where we maintain our source code. As you pointed this repo doesn't use "P1-Beta" tag as it contains only the source code but no binaries. Going forward, I will maintain the same tag in both the repos (OpenSSH-Portable and Win32-OpenSSH).