PowerShell / WindowsCompatibility

Module that allows Windows PowerShell Modules to be used from PSCore6
Other
137 stars 33 forks source link

First version of the Compatibility Session commands #1

Closed BrucePay closed 6 years ago

BrucePay commented 6 years ago

This is the first version of the commands for creating and using "compatibility sessions" - PSSessions used to allow PowerShell 6 to call PowerShell 5 commands using proxies and local remoting. This PR includes the WPSCompatibilityPack module along with a fairly minimal set of tests. Documentation is provided for all commands using comment-based help.

markekraus commented 6 years ago

The Encoding of the PSD1 is UTF-16 LE. Can this be change to UTF-8 (No-BOM)?

iSazonov commented 6 years ago

As for aliases we have PowerShell Committee conclution to delegate them to users. So I'd defer this aliases until we get the RFC.

markekraus commented 6 years ago

@iSazonov While I am not a fan of aliases in general. It is important to note that this is a module that is separate from PowerShell. It is acceptable for module authors to include aliases for their commands, even when those module authors are PowerShell team members. The conclusion as I understand it is geared more towards PowerShell proper where adding and removing aliases has unexpected impacts on users.

SteveL-MSFT commented 6 years ago

Thanks everyone for the feedback. Since this is a preview version, we can continue to iterate on the feedback and breaking changes are acceptable for this module.