search

PowerShell / WindowsCompatibility

Module that allows Windows PowerShell Modules to be used from PSCore6
Other
137 stars 33 forks source link

Enable module to work on Windows PowerShell 5.1 #8

Closed SteveL-MSFT closed 6 years ago

SteveL-MSFT commented 6 years ago

Need this module to work on Windows PowerShell 5.1 to enable PowerShell Modules built with .Net Std 2.0 and Windows Compat Pack work correctly.

Added .gitattributes so EOL is consistent Added build.ps1 Updated tests to allow running from root of repo (or any folder) Tests expect project to be built so that WCP assemblies are populated (hence running from publish folder) Change reference to PS Std Lib 5.1 so that it builds correctly Update psd1 to allow running on 5.1 and explicitly added all WCP assemblies so they are found in Windows PowerShell 5.1 Updated Add-WindowsPSModulePath to be no-op on Windows PowerShell and added test VSCode fixed a bunch of trailing whitespace

markekraus commented 6 years ago

@SteveL-MSFT I'm curious, why does this module need to work on Windows PowerShell? Isn't the entire point of it to run on Core to make Windows PowerShell features/modules present in PowerShell Core? is this some internal requirement?

SteveL-MSFT commented 6 years ago

@markekraus if you port or create a PowerShell module that uses WCP and .Net Std 2.0 you need to include the referenced WCP assemblies so that the CLR knows how to find the implementation (whether on coreClr or fullClr).