search

PowerShell / platyPS

Write PowerShell External Help in Markdown
MIT License
765 stars 149 forks source link

Resolve the assembly conflict that could be caused by PlatyPS #587

Closed daxian-dbw closed 2 years ago

daxian-dbw commented 2 years ago

PR Summary

PlatyPS depends on YamlDotNet, which is a very common dependency of many other module, such as powershell-yaml. Due to the different versions that different modules may depend on, this could cause a conflict in assembly loading when importing those modules in the same PowerShell session.

This PR rearranges the module folder structure, as well as how to load those the dependencies, so as to avoid PlatyPS from causing the assembly conflicts.

PR Context

Reference: https://github.com/PowerShell/PowerShell/issues/2083 See the comment https://github.com/PowerShell/PowerShell/issues/2083#issuecomment-1063583411

daxian-dbw commented 2 years ago

@adityapatwardhan Please review when you have time. Thanks!

adityapatwardhan commented 2 years ago

Changes look good. I have fixed the CI, so it will run tests now.