search

PowerShell / vscode-powershell

Provides PowerShell language and debugging support for Visual Studio Code
https://marketplace.visualstudio.com/items/ms-vscode.PowerShell
MIT License
1.69k stars 480 forks source link

ISE Mode Settings Restore #2527

Open mattmcnabb opened 4 years ago

mattmcnabb commented 4 years ago

Summary of the new feature

Great job on the new ISE Mode commands! However, when I switch to ISE Mode I'd like to be able to easily switch back to the settings I previously had configured. What are your thoughts on adding a backup feature to the affected settings so that when you disable ISE Mode these can be properly restored?

Proposed technical implementation details (optional)

I think the previous settings could be cached or backed up in a way that would make them easy to restore. For instance, maybe the existing settings could just be prefixed with "ISE_Mode" or somesuch and this can be reverted on disable.

rjmholt commented 4 years ago

I seem to recall discussing this when the feature was implemented, but we decided to let the work be request before we did it.

I think it's a fair ask.

TylerLeonhardt commented 4 years ago

I'm just curious... Why are you disabling ISE Mode?

The intent of ISE Mode was to give users who are afraid of vscode a way to use a simpler experience.

If you don't need a simpler experience, then you can pick and choose the settings you want to keep from ISE Mode by either turning it on and removing the ones you don't want

Or

Read our doc that breaks down the settings that ISE Mode applies and add the ones you want:

aka.ms/isecompat

borisimple commented 4 years ago

@mattmcnabb This is definitely something useful. I would like to have that option as well.

mattmcnabb commented 4 years ago

I'm just curious... Why are you disabling ISE Mode?

The intent of ISE Mode was to give users who are afraid of vscode a way to use a simpler experience.

If you don't need a simpler experience, then you can pick and choose the settings you want to keep from ISE Mode by either turning it on and removing the ones you don't want

Or

Read our doc that breaks down the settings that ISE Mode applies and add the ones you want:

aka.ms/isecompat

@TylerLeonhardt It's not really so much for me, it's more of a general request. If a user (not me) switches to ISE mode, even just to test it out, they lose any conflicting settings they might have had configured. Since ISE mode provides a custom set of configurations the process for switching back is a bit different than just switching themes. Once in ISE mode I can switch to a different theme but can't revert all the associated settings. I think that could be a problem, particularly for beginners in VS Code who may not know how to get back to previous settings.