PowerShell / vscode-powershell

Provides PowerShell language and debugging support for Visual Studio Code
https://marketplace.visualstudio.com/items/ms-vscode.PowerShell
MIT License
1.67k stars 478 forks source link

Review: 1.90.0 VSCode Native PowerShell IntelliSense Issues #5000

Open JustinGrote opened 4 weeks ago

JustinGrote commented 4 weeks ago

Prerequisites

Summary

1.90 has some new preview PowerShell Intellisense https://code.visualstudio.com/updates/v1_90#_vs-codenative-intellisense-for-powershell

image

Should probably make sure there aren't any conflicts with this extension. I'm sure they tested, but still.

This is an overall tracker to open issues over in the VSCode repository if they don't get fixed or aren't being tracked otherwise, so we will need to mitigate or provide warnings in our extension if we detect it is enabled.

VSCode Tracking Issue

Observed Issues

JustinGrote commented 4 weeks ago

@andyleejordan are you in any coordination with the vscode team on this?

Tyriar commented 3 weeks ago

@JustinGrote we sync up every month. I don't directly test the pwsh extension and I'm not aware of any conflicts. The 3 latter issues you mention seem like they should be tracked in new VS Code issues.

Hijacks Tab and Ctrl-Enter PSReadline, doesn't complete in a manner expected by PS

If you mean it's hijacked when the suggest widget is visible, this is by design. Everything except for ctrl+space should work the same as before when it's hidden (via escape, configure settings to change when it's shown).

JustinGrote commented 3 weeks ago

Sounds great! This was mostly to verify as a sanity check, and as mentioned, I'll open issues as-found once I have more time to evaluate.