search

PowerShellEmpire / PowerTools

PowerTools is a collection of PowerShell projects with a focus on offensive operations.
Other
2.03k stars 817 forks source link

Fix Test-ServiceDaclPermission #71

Closed sagishahar-zz closed 8 years ago

sagishahar-zz commented 8 years ago

The Implementation was corrected such that the permissions of the effective user (i.e. nested groups) are also checked. Additionally, Get-ServiceDaclPermission was removed as it is not necessary. Lastly, a few other minor updates were made to increase efficiency.

HarmJ0y commented 8 years ago

Was this one meant for master? Happy to land it, just checking (landed https://github.com/PowerShellEmpire/PowerTools/pull/72)

sagishahar-zz commented 8 years ago

Yes this one is for master. Thanks for landing the other PR.

HarmJ0y commented 8 years ago

Would it be easier for me to stop being a shitty code manager and just merge the powersploit_fixup branch to master? I'm thinking this might simplify things as opposed to having two branches with diverging code bases. If I kill this one and merge the powersploit branch into master, would it be too much of a pain to resubmit the additional logic changes? Apologies for making this more difficult than it should have been!!

sagishahar-zz commented 8 years ago

I agree with you 100%, things will be more simplified and easier to manage if the branches are merged as you suggested. Unless we are going for the DACL solution instead of catching sc.exe errors no additional logic changes will be required. Please let me know your final decision about the matter but either way it won't be a pain at all so no worries ;)

HarmJ0y commented 8 years ago

Cool, closing this guy- the fixup branch is now merged.