search

PowerShellOrg / StackExchangeResources

DSC Resources from Stack Exchange
MIT License
13 stars 8 forks source link

Add Password parameter, and change Test-TargetResource to match the Subj... #3

Open mcraig88 opened 10 years ago

mcraig88 commented 10 years ago

Add Password parameter, and change Test-TargetResource to match the Subject name, instead of looking for equal to.

This has been tested on Windows 2008R2 and 2012R2.

mcraig88 commented 10 years ago

Windows 2012 will use Import-PfxCertificate, Windows 2008 will use certutil.

dlwyatt commented 10 years ago

I don't think it's a good idea to have any kind of wildcard matching on a DSC resource's key property.

Adding support for PFX passwords is a good idea, but using a [string] for this is not secure. Off the top of my head, I don't remember if we can just stick a [securestring] argument in there and have itwork, or if DSC will only encrypt PSCredential parameters for you (with corresponding MSFT_Credential objects in the MOF file.) Will test that soon.

dlwyatt commented 10 years ago

You could use a wildcard certificate while still using the -eq operator in PowerShell. The * character would just be part of the certificate's subject.

I do agree that using a thumbprint might have been a better choice. The question now would be whether we should make a breaking change on the resource now to change its API, or just leave it as-is.

mcraig88 commented 10 years ago

Ok, I'll see what I can do here.