Powerlevel9k / powerlevel9k

Powerlevel9k was a tool for building a beautiful and highly functional CLI, customized for you. P9k had a substantial impact on CLI UX, and its legacy is now continued by P10k.
https://github.com/romkatv/powerlevel10k
MIT License
13.47k stars 947 forks source link

Get rid of absolute versions for Dockerfiles #1118

Closed dritter closed 5 years ago

dritter commented 5 years ago

The Dockerfiles break regularly because of distros releasing patches for ZSH and it seems to be impossible to install a fuzzy version of ZSH (like 5.6.2-*) with apt-get. This PR switches to apt that has that ability.

//cc @Syphdias

Syphdias commented 5 years ago

Looks good to me. Though I cannot speak for 4.3.11 since the centos image throws a segfault on running yum, bash or sh (dash works). I think that's a local problem with my machine.

Syphdias commented 5 years ago

Currently the centos:6 image seems to be broken (also for a colleague). The centos:7 image works.

dritter commented 5 years ago

Hmm. What exactly do you mean by saying the image is "broken"? Is it not possible to start the docker container? Or is just P9K broken inside the container? Thinking about it, that is only there because of historical reasons. Our new minimum system requirement is ZSH 5.1..

Syphdias commented 5 years ago

As I said, I (and my colleague) get segfaults for starting various programs inside the container. We both use Debian (different version I think).

And since I can run the version with the label 7 from dockerhub. I assume the latest image from dockerub is faulty. Could be my system though.

 ❱ docker run --rm -it centos:7 /bin/bash                                            
[root@3c19cabe14ad /]# ^C
[root@3c19cabe14ad /]# exit
^[[A%                                                                                                                                                                                                                ❱ docker run --rm -it centos:6 /bin/bash
 ❱ echo $?     
139
 ❱ docker run --rm -it centos:6 /bin/dash
# yum
Segmentation fault (core dumped)
# echo $?
139
# /bin/bash
Segmentation fault (core dumped)
# echo $? 
139
# % 
Syphdias commented 5 years ago

Ok apparently this is a know bug

dritter commented 5 years ago

Alright. I merged it. Thanks for the review @Syphdias .