search

Powerlevel9k / powerlevel9k

Powerlevel9k was a tool for building a beautiful and highly functional CLI, customized for you. P9k had a substantial impact on CLI UX, and its legacy is now continued by P10k.
https://github.com/romkatv/powerlevel10k
MIT License
13.47k stars 947 forks source link

[Bugfix] allow set -u to be used #1132

Closed docwhat closed 5 years ago

docwhat commented 5 years ago

The surface functions and if cases may be called by a script, which means they should work even with set -uset.

dritter commented 5 years ago

Hi @docwhat , Thanks for the PR. In the meantime I merged some big changes, could you update your PR?

Is there a way to test this automated? I'm asking, because I feel that this is something I'll eventually forget in future changes.. ;)

Thx.

docwhat commented 5 years ago

I'm not sure it is worth it without a test.

Basically, the test would be something like

function someTest() {
  setopt local_options
  set -u
  # Run the two scripts I modified.
}
docwhat commented 5 years ago

Okay, I pushed up changes with a test.

Something still isn't working. If anyone wants to help?

dritter commented 5 years ago

I just restarted the Tests. That was a hiccup in the Travis OSX VMs again.. Now everything is green. Merging. Thx @docwhat