[Enhancement] Adding own gitconfig for git tests

Powerlevel9k / powerlevel9k

Powerlevel9k was a tool for building a beautiful and highly functional CLI, customized for you. P9k had a substantial impact on CLI UX, and its legacy is now continued by P10k.

https://github.com/romkatv/powerlevel10k

MIT License

13.47k stars 947 forks source link

[Enhancement] Adding own gitconfig for git tests #1139

Closed Syphdias closed 5 years ago

Syphdias commented 5 years ago

This PR does some modifications to the git unit tests:

sets HOME to test folder so the global .gitconfig is created in this folder. (I just realized that the setting of OLD_GIT_AUTHOR_EMAIL and OLD_GIT_AUTHOR_NAME is also made unnecessary by this since the real global gitconfig is never touched)
also: removes redundant setup and tear-down code
also: modifies two tests to be more explicit and consistent with other commands (not output)

Syphdias commented 5 years ago

Removing the git inits from the test makes them dependant on each other.. Was this done because of performance reasons?

As I understand it, the setUp and tearDown run separately for each test function. So the the cd $FOLDER and git init is already done in setUp. So this shouldn't introduce extra dependencies, should it?

dritter commented 5 years ago

Ha! You are right. I didn't see that because it was already there and therefore didn't show up in the diff.

dritter commented 5 years ago

Thx @Syphdias .