search

Powerlevel9k / powerlevel9k

Powerlevel9k was a tool for building a beautiful and highly functional CLI, customized for you. P9k had a substantial impact on CLI UX, and its legacy is now continued by P10k.
https://github.com/romkatv/powerlevel10k
MIT License
13.47k stars 947 forks source link

removing vcs-detect-changes from POWERLEVEL9K_VCS_GIT_HOOKS unexpectedly removes remote repo icon #1207

Closed romkatv closed 5 years ago

romkatv commented 5 years ago

Tested on master with the default config.

  1. Clone a repo from github.
  2. cd into it.
  3. Observe the presence of github icon in the vcs prompt.
  4. Remove vcs-detect-changes from POWERLEVEL9K_VCS_GIT_HOOKS. That is, set POWERLEVEL9K_VCS_GIT_HOOKS=(git-untracked git-aheadbehind git-stash git-remotebranch git-tagname). Restart zsh.
  5. Repeat steps 1-2.
  6. Observe the absence of github icon in the vcs prompt.

Expected: There is a github icon in the vcs prompt in 6. Actual: There isn't.

That being said, it's undocumented how the presence or absence of hooks affects vcs segment. It would be nice to have it documented. But either way the current behavior is very surprising.

dritter commented 5 years ago

This is fixed on next with merging #1235 . Closing for now.