search

Powerlevel9k / powerlevel9k

Powerlevel9k was a tool for building a beautiful and highly functional CLI, customized for you. P9k had a substantial impact on CLI UX, and its legacy is now continued by P10k.
https://github.com/romkatv/powerlevel10k
MIT License
13.47k stars 947 forks source link

add option to virtualenv prompt for show eventually python version [Enhancement] #1233

Closed jerome-diver closed 5 years ago

jerome-diver commented 5 years ago

Description

for prompt_virtualenv, i see other guys asked for see python version inside the virtual environment used with virtualenv. It is possible by add an option (read the README.md file on this segment, i tryed to follow the way to pull request (firts time!). Tell me if i do wrong. Works perfectly on my system and oing to pull request also on powerlevel10k forked project.

Syphdias commented 5 years ago

Hey @jerome-diver,

thank you for your PR, unfortunately you have included pretty much every change from https://github.com/romkatv/powerlevel10k. This makes merging impossible.

The way you would usually open a PR is to:

  1. Fork the project
  2. Checkout the branch you want to open a pull request against
  3. Create a new branch "fancy-new-feature"
  4. Change stuff
  5. Commit your changes to the new branch
  6. Push your changes to your fork
  7. Open a PR on GitHub

HTH Syphdias

Syphdias commented 5 years ago

Closing in favour of #1234