[Enhancement & Bug?] Better P9K_VPN_IP_INTERFACE default

Powerlevel9k / powerlevel9k

Powerlevel9k was a tool for building a beautiful and highly functional CLI, customized for you. P9k had a substantial impact on CLI UX, and its legacy is now continued by P10k.

https://github.com/romkatv/powerlevel10k

MIT License

13.47k stars 947 forks source link

[Enhancement & Bug?] Better P9K_VPN_IP_INTERFACE default #1240

Closed Syphdias closed 5 years ago

Syphdias commented 5 years ago

This is a small change to also register interfaces that are not just tun but also every interface that starts with "tun".

I do have another problem though: My non-active VPN interface (tap0) is UP and my actually working VPN (tun0) ins UNKNOWN. p9k::parseIp currently needs the interface to be UP. This breaks the segment for me atm.

❯ /sbin/ip -brief -4 a show
lo               UNKNOWN        127.0.0.1/8 
wlp42s0          UP             10.4.5.6/24 
tap0             UP             10.3.4.5/24 
docker0          DOWN           10.2.3.4/27 
tun0             UNKNOWN        10.1.2.3/32

dritter commented 5 years ago

I'm going to merge this, as the change is fairly small. About your issue with the UNKNOWN state of your tunnel. Well, that is not a thing P9K can handle, as UNKNOWN can mean anything.. Do you have an idea how to change that check?

Syphdias commented 5 years ago

Do you have an idea how to change that check?

Sadly, no, it might be an openconnect bug, but I couldn't find anything on it. Manually setting the interface to up did nothing. The VPN works well though... 🤷‍♀

Well, that is not a thing P9K can handle, as UNKNOWN can mean anything..

Agreed.