[Enhancement] Bold Icons

Powerlevel9k / powerlevel9k

Powerlevel9k was a tool for building a beautiful and highly functional CLI, customized for you. P9k had a substantial impact on CLI UX, and its legacy is now continued by P10k.

https://github.com/romkatv/powerlevel10k

MIT License

13.46k stars 948 forks source link

[Enhancement] Bold Icons #1264

Closed Syphdias closed 5 years ago

Syphdias commented 5 years ago

Instead of _BACKGROUND, _FOREGROUND or _ICON you can append:

_BOLD to the stateful name to get bold text
_ICON_BOLD to the stateful name to get bold visual identifier/"icon" (this only works if the font allows for it to be bold)

The _BOLD feature seems to be undocumented which should be changed. And also document _ICON_BOLD next to it.

aims to resolves #1223

bhilburn commented 5 years ago

This is a much better way to have done this, thanks @Syphdias.

And yes, great point regarding the missing documentation - this should really be added to the README. Were you planning on pushing a separate PR for that?

Syphdias commented 5 years ago

Were you planning on pushing a separate PR for that?

Like #1265? 😉

Syphdias commented 5 years ago

I just checked.This has the same issue as described in #1302 in ZSH 5.2

dritter commented 5 years ago

I just checked.This has the same issue as described in #1302 in ZSH 5.2

Thanks for checking. I'm merging anyway, as this is on the path to v0.7.0.

Thanks for the PR @Syphdias .