[Bugfix] Simplifing pyenv and rbenv to get rid of unexpected behaviour

Powerlevel9k / powerlevel9k

Powerlevel9k was a tool for building a beautiful and highly functional CLI, customized for you. P9k had a substantial impact on CLI UX, and its legacy is now continued by P10k.

https://github.com/romkatv/powerlevel10k

MIT License

13.46k stars 948 forks source link

[Bugfix] Simplifing pyenv and rbenv to get rid of unexpected behaviour #1285

Closed Syphdias closed 5 years ago

Syphdias commented 5 years ago

I removed some of the complexity and manual checking for versions. pyenv and rbenv should:tm: take care of that themselves. This seems to me like the most straight forward solution to not introducing unexpected behaviour. This would also close 3 issues (and 2 PRs I opened without simplifying code).

I did only very little testing since I know very little about pyenv and rbenv and these segments have no unit test.

bhilburn commented 5 years ago

Ugh, still waiting for Travis to finish >:(

bhilburn commented 5 years ago

FINALLY! Tests complete =)

This branch had a conflict, which I resolved.

I really like this PR. In addition to fixing those bugs, this is dramatically simpler code. Thanks, @Syphdias, and I think you should be good to close those other bugs! =)