Closed Syphdias closed 5 years ago
Ugh, still waiting for Travis to finish >:(
FINALLY! Tests complete =)
This branch had a conflict, which I resolved.
I really like this PR. In addition to fixing those bugs, this is dramatically simpler code. Thanks, @Syphdias, and I think you should be good to close those other bugs! =)
I removed some of the complexity and manual checking for versions.
pyenv
andrbenv
should:tm: take care of that themselves. This seems to me like the most straight forward solution to not introducing unexpected behaviour. This would also close 3 issues (and 2 PRs I opened without simplifying code).I did only very little testing since I know very little about
pyenv
andrbenv
and these segments have no unit test.