search

Powerlevel9k / powerlevel9k

Powerlevel9k was a tool for building a beautiful and highly functional CLI, customized for you. P9k had a substantial impact on CLI UX, and its legacy is now continued by P10k.
https://github.com/romkatv/powerlevel10k
MIT License
13.46k stars 949 forks source link

Error in Setup Instructions - Readme #1348

Open altimmons opened 4 years ago

altimmons commented 4 years ago

Here:

https://github.com/Powerlevel9k/powerlevel9k/wiki/Install-Instructions#step-1-install-powerlevel9k

Verified now on 3 machines. (all debian based though)

Instructions say add:

echo 'source /usr/share/zsh-theme-powerlevel9k/powerlevel9k.zsh-theme' >> ~/.zshrc

but $whereis powerlevel9k

gives /usr/share/powerlevel9k

thus

echo 'source /usr/share/powerlevel9k/powerlevel9k.zsh-theme' >> ~/.zshrc

works correctly. Perhaps its a Pacman vs. Apt difference... but it could be noted just below.

romkatv commented 4 years ago

If you aren't using Arch, installation instructions for Arch won't work for you. Likewise with NixOS and macOS -- you should follow these installation instructions only if you are using NixOS and macOS respectively.

altimmons commented 4 years ago

Well, the differences between arch and Debian aren’t significant enough to really play a major difference here. Either apt package is configured slightly different than that Pacman / yum varietals (which is a bug), or the readme page is wrong (which is a bug).

Both minor. But since most the posts here are about people complaining its hard to configure / install, it's worth the minor change.

On Aug 3, 2019, at 6:35 AM, Roman Perepelitsa notifications@github.com wrote:

If you aren't using Arch, installation instructions for Arch won't work for you. Likewise with NixOS and macOS -- you should follow these installation instructions only if you are using NixOS and macOS respectively.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

romkatv commented 4 years ago

Well, the differences between arch and Debian aren’t significant enough to really play a major difference here. Either apt package is configured slightly different than that Pacman / yum varietals (which is a bug), or the readme page is wrong (which is a bug).

Maybe. I wouldn't call it an error in setup instructions though. A more faithful bug report would read: "Installations instructions for Arch don't work on Debian. Well, obviously they don't, but I've changed them according to The Standard Rules For Converting Arch Installation Instructions To Debian, and they still don't work."

I don't use Arch myself, so I don't know how standard The Standard Rules are. I'm also not a Powerlevel9k dev, so my opinion is irrelevant other way.

altimmons commented 4 years ago

Granted.

Yet with the simple tweak of changing the destination directory In the Deb package- just dropping a single word from the directory name-

You no longer have “Arch Linux installation instructions” and comments like “it says arch so obviously it doesn’t work” -then they’re just Linux installation instructions.

There aren’t architectural differences here - there are the usual open source issues of everyone being on almost, but not quite on the same page.

It’s minor. And in a way it separates the noobs who want a l33t looking terminal from those who should probably know how to fix it anyway.

In a way I see it more of an esoteric debate - whether you’re in the “user friendly Linux for all And for all a GUI” camp or in the “I’m so hardcore I browse the Internet in VIM camp”

An option- of course - is just to add the “Debian/ Ubuntu” specific instructions to the Readme.md. But then that just looks sloppy. I figured it ended up saying Arch installation instructions in the first lplace when someone complained it didn’t work on Ubuntu. Just something for the next major release

On Aug 5, 2019, at 4:33 PM, Roman Perepelitsa notifications@github.com wrote:

Well, the differences between arch and Debian aren’t significant enough to really play a major difference here. Either apt package is configured slightly different than that Pacman / yum varietals (which is a bug), or the readme page is wrong (which is a bug).

Maybe. I wouldn't call it an error in setup instructions though. A more faithful bug report would read: "Installations instructions for Arch don't work on Debian. Well, obviously they don't, but I've changed them according to The Standard Rules For Converting Arch Installation Instructions To Debian, and they still don't work."

I don't use Arch myself, so I don't know how standard The Standard Rules are. I'm also not a Powerlevel9k dev, so my opinion is irrelevant other way.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

romkatv commented 4 years ago

Yet with the simple tweak of changing the destination directory In the Deb package- just dropping a single word from the directory name-

Sounds reasonable. Maybe also add a symlink to avoid breaking existing users. (Note again that my opinion is as authoritative as yours.)

In a way I see it more of an esoteric debate - whether you’re in the “user friendly Linux for all And for all a GUI” camp or in the “I’m so hardcore I browse the Internet in VIM camp”

Never heard of these camps and I don't belong to either.

FWIW, I maintain a different ZSH theme that doesn't provide a debian package and no one has ever asked for it. Which is just as well because there are better ways to install ZSH themes and plugins.

altimmons commented 4 years ago

agree completely. Replace Debian with Arch/Any other distro and we are talking about the same thing.

On Tue, Aug 6, 2019 at 4:05 AM Roman Perepelitsa notifications@github.com wrote:

Yet with the simple tweak of changing the destination directory In the Deb package- just dropping a single word from the directory name-

Sounds reasonable. Maybe also add a symlink to avoid breaking existing users. (Note again that my opinion is as authoritative as yours.)

In a way I see it more of an esoteric debate - whether you’re in the “user friendly Linux for all And for all a GUI” camp or in the “I’m so hardcore I browse the Internet in VIM camp”

Never heard of these camps and I don't belong to either.

FWIW, I maintain a different ZSH theme that doesn't provide a debian package and no one has ever asked for it. Which is just as well because there are better ways to install ZSH themes and plugins.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Powerlevel9k/powerlevel9k/issues/1348?email_source=notifications&email_token=ADU23JIRVDW7GU2JUXVWLGDQDEWFRA5CNFSM4IJCBNQ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3UJFAQ#issuecomment-518558338, or mute the thread https://github.com/notifications/unsubscribe-auth/ADU23JPPRSGVYXU6DWFAAQLQDEWFRANCNFSM4IJCBNQQ .