[VSCode] Bug in Visual Studio Code Terminal

Powerlevel9k / powerlevel9k

Powerlevel9k was a tool for building a beautiful and highly functional CLI, customized for you. P9k had a substantial impact on CLI UX, and its legacy is now continued by P10k.

https://github.com/romkatv/powerlevel10k

MIT License

13.46k stars 946 forks source link

[VSCode] Bug in Visual Studio Code Terminal #1350

Open bythckr opened 5 years ago

bythckr commented 5 years ago

I am on Mac OS Mojave, I am using oh-my-zsh+iTerm2+powerlevel9k+awesome-patched.

But now when I am trying to use the terminal, its having issue with the emojis/unicode (the branch shape, what is the right term?).

Under the understanding (I might be wrong), that VSCode's terminal is reading the .zshrc. I am assuming that it read POWERLEVEL9K_MODE='awesome-patched'. I set the font to "terminal.integrated.fontFamily": "'SourceCodePro+Powerline+Awesome+Regular',", in vscode's settings.json.

My VSCode:

My VSCode with "terminal.integrated.fontFamily": "Inconsolata-dz for Powerline",:

My iTerm on 'awesome-patched' mode in .zshrc & SourceCodePro+Powerline+Awesome+Regular in iterm preference:

Inconsolata-dz for Powerline was suggested.

What else could I try?

romkatv commented 5 years ago

I set the font to "terminal.integrated.fontFamily": "'SourceCodePro+Powerline+Awesome+Regular',", in vscode's settings.json.

You need to remove that trailing comma from fontFamily.

- "terminal.integrated.fontFamily": "'SourceCodePro+Powerline+Awesome+Regular',",
+ "terminal.integrated.fontFamily": "'SourceCodePro+Powerline+Awesome+Regular'",

romkatv commented 5 years ago

It's also possible that you need to replace one + with space.

"terminal.integrated.fontFamily": "'SourceCodePro+Powerline+Awesome Regular'",

bythckr commented 5 years ago

The trailing comma & the + between Awesome & Regular was the issue. 2 rather silly issues, silly me. Thanks a lot.

There is still one more issue. Repeating the command in the output line. Why is that?

romkatv commented 5 years ago

There is still one more issue. Repeating the command in the output line. Why is that?

I don't see anything about repeating the command in the output line in the issue description. Can you elaborate?

bythckr commented 5 years ago

VS Code Terminal: (Note the repeating command circled in red)

iTerm:

romkatv commented 5 years ago

Indeed, that looks pretty bad. Your iTerm also looks kinda broken.

By the way, you are using the original Powerlevel9k, right?

bythckr commented 5 years ago

original Powerlevel9k, right?

I am sorry, I don't understand "original"? I downloaded from https://github.com/Powerlevel9k/powerlevel9k/.

romkatv commented 5 years ago

original Powerlevel9k, right?

I am sorry, I don't understand "original"? I downloaded from https://github.com/Powerlevel9k/powerlevel9k/.

Yes, that's the one. I just wanted to make sure we are talking about the same thing.

bythckr commented 5 years ago

what do I do?

romkatv commented 5 years ago

Maybe some of the powerlevel9k developers or users will help. (I'm neither.)

bythckr commented 5 years ago

(I'm neither.)

I assumed that you are the lead developer. None the less, your support so far has been great. Thanks a lot

romkatv commented 5 years ago

@bythckr It appears that this issue is not specific to Powerlevel9k. See https://github.com/romkatv/powerlevel10k/issues/199. Perhaps the resolution on that issue will help you, too.