All Leader Content should show Group Avatar in Newsfeed, not Author Avatar

[jterps08]

Currently system provides the Author avatar with the leader content. The system should provide the Group avatar with the leader content (polls/leader-petitions/discussions/fundraisers/events/announcements).

User posts and user petitions (boosted and non-boosted) should continue to show author avatar.

Served with imgix as usual.

[jterps08]

@igaponov is this something you would change on the backend or is this something that we would have changed on the frontend?

[igaponov]

Use activity.group.avatar_file_path to get link.

[jterps08]

Thanks Igor. So we'll use that to get the link. @devotebest when it's time to do this, we'll need to make sure imgix parameters are applied as usual.

Group avatar displayed for new polls, leader petitions, discussions, fundraisers, and events. User posts and user petitions will continue to show user avatars.

[jterps08]

Image on the left is the main newsfeed. Image all the way to the right is related to the feed that is shown in User Profile screen (#452)

[jterps08]

@oleg201119 this should be pretty straight forward based on explanation above, but let me know if you have any questions... If User A is a group owner/manager of Group X, and he creates a user post or user petition, then User A avatar is shown in the newsfeed. If User is a group owner/manager of Group X and he creates leader content (poll/leader-petition/discussion/fundraiser/event/announcement), then the Group X avatar is show in the newsfeed. It should simply be a matter of logic checking "If group content, show group avatar... if user content, show user avatar" Currently system always displays user avatar.

We want to make sure the images continue to be served using the standard imgix image compression technique that is being used in the newsfeed currently for user avatars.

[oleg201119]

@jterps08 I am trying to change avatar for a user and a group for testing. But can't change profile avatar. The activity feed screen and profile screen shows default "character avatar" only. How to upload/change avatar picture ?

[jterps08]

Tap the edit button in upper right corner for user profile to activate profile editing.

Tap the manage group button on the group profile screen to activate profile editing and change group avatar.

On Mar 22, 2017 12:46 PM, "oleg201119" notifications@github.com wrote:

@jterps08 https://github.com/jterps08 I am trying to change avatar for a user and a group for testing. But can't change profile avatar. The activity feed screen and profile screen shows default "character avatar" only. How to upload/change avatar picture ?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/PowerlineApp/powerline-mobile/issues/475#issuecomment-288462615, or mute the thread https://github.com/notifications/unsubscribe-auth/AHOy-RkuZ7r7vSPHbMB-znKU0bRF2xx0ks5roVBhgaJpZM4LscRH .

[oleg201119]

I did, but avatar image is disappeared on profile edit screen once image is selected from photo library.

[jterps08]

What's wrong? Please show a screenshot. If it's a frontend problem, we'd ask you to fix it anyway

[oleg201119]

[oleg201119]

If I click 'save' button on this screen, the app shows 'success', but feed page and profile page shows 'character avatar' again. Not 'image avatar'.

[jterps08]

@igaponov can you take a look at this? Is this an imgix serving issue?

User updates personal profile avatar. Clicks Save. App indicates successful save, but user profile page and newsfeed remain unchanged.

[igaponov]

Probably an sql error with reports causes this problem, need to retest after a deploy to dev.

[jterps08]

@igaponov can you explain in more detail / deploy today?

[jterps08]

What is the status with this @oleg201119 ?

[oleg201119]

@jterps08 I can't upload image for group..

[jterps08]

That is definitely a bug that we will need @igaponov to look at (user and group avatar upload)...

But @oleg201119 - You shouldn't need that fixed to fix this issue ... if there's no image, the ng-letter concept shows instead... if user Oleg posts a poll in group X, right now it shows the "O" avatar (ng-letter). after the code change, if user Oleg posts a poll, the "X" avatar will show in newsfeed (ng-letter) for group X...

We need to fix the upload problem separately.

[oleg201119]

@jterps08 this issue is fixed if there's no image. But I got a problem if there is image. The api returns 3 images for an activity. ( group image, user image and owner image). And group image and user image are default image, but owner image is the image I uploaded. So how to show image for avatar ? @igaponov Can you check this problem ?

[jterps08]

I don't know what the difference is between user image and owner image...

@igaponov this image upload issue doesn't seem to exist on PROD... are we sure these query optimizations and everything else you've been working on hasn't negatively impacted dev stability?

[jterps08]

confirmed