search

PowerlineApp / powerline-mobile

Other
4 stars 16 forks source link

STAGING - Notification Registration Authentication Error #604

Closed jterps08 closed 7 years ago

jterps08 commented 7 years ago

I'm assuming this is related to the authentication change made to the API? We need the api to be backwards compatible as we're not making another Ionic release to the app store. User is kicked back out to Login screen after this error, but can log back in with no problem. user abc2

image

igaponov commented 7 years ago

User should be authorized to access this endpoint, it's frontend issue.

jterps08 commented 7 years ago

Sigh. Okay. I don't know why this didn't happen in Dev before with the dev build. Maybe it did and I ignored it somehow? I'm not sure. We can't deploy this v2.1.1 release to PROD if it's going to break new user registration and device notification registration on the v2.1.0 Ionic app.

So, what this means is that v2.1.1 cannot go to PROD until RN app is ready to replace Ionic app in app stores (or if that looks like we'll miss our mid-July target, we might have to have the Ionic app updated). Do you agree @igaponov ? I need a little extra perspective on this. There is no urgency to deploying v2.1.1 to prod with v2.1 ionic app unchanged, right? The only real benefit would be at-everyone mention.

igaponov commented 7 years ago

@jterps08 nothing was changed for device registration, Ionic app should work with 2.1.1 version of backend. There is no sense to wait for RN app, because it needs some features from v2.1.2 (590, 596,597 for example)

jterps08 commented 7 years ago

@igaponov I registered another user abc3 on STAGING and did NOT experience 604. Closing.